pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Gregory Stark <stark@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@commandprompt.com>
Cc: Josh Berkus <josh@agliodbs.com>
Cc: Heikki Linnakangas <heikki@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org
Cc: Robert Treat <xzilla@users.sourceforge.net>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: Greg Smith <gsmith@gregsmith.com>
Cc: Andreas Pflug <pgadmin@pse-consulting.de>
Cc: Decibel! <decibel@decibel.org>
Subject: Re: Overhauling GUCS
Date: Thu, 12 Jun 2008 01:26:09 +0100
Message-ID: <87od674hy6.fsf@oxford.xeocode.com> (raw)
In-Reply-To: <11913.1213218315@sss.pgh.pa.us>
References: <48409D1E.3070208@agliodbs.com>
	<200806061624.29105.xzilla@users.sourceforge.net>
	<200806100937.38124.josh@agliodbs.com>
	<200806100949.17918.josh@agliodbs.com>
	<21875.1213122184@sss.pgh.pa.us>
	<484F7613.5070202@enterprisedb.com>
	<484FFF06.9010307@agliodbs.com>
	<20080611163847.GN5352@alvh.no-ip.org>
	<11913.1213218315@sss.pgh.pa.us>

"Tom Lane" <tgl@sss.pgh.pa.us> writes:

> Alvaro Herrera <alvherre@commandprompt.com> writes:
>> Josh Berkus wrote:
>>> Ideally, of course, there would be no wal_buffers setting, and WAL  
>>> buffers would be allocated from shared_buffers pool on demand...
>
>> Same for pg_subtrans, pg_clog, etc (as previously discussed)
>
> I agree with that for pg_clog and friends, but I'm much more leery of
> folding WAL into the same framework.  Its access pattern is *totally*
> unlike standard caches, so the argument that this would be good for
> performance is resting on nothing but imagination.  Also I'm concerned
> about possible deadlocks, because WAL is customarily accessed while
> holding one or more exclusive buffer locks.

Well it may still be worthwhile stealing buffers from shared_buffers even if
we set a special flag marking them as owned by WAL and out of bounds for
the normal buffer manager.

At least that way we could always steal more if we want or return some, as
long as we're careful about when we do it. That would open the door to having
these parameters be dynamically adjustable. That alone would be worthwhile
even if we bypass all bells and whistles of the buffer manager.

-- 
  Gregory Stark
  EnterpriseDB          http://www.enterprisedb.com
  Ask me about EnterpriseDB's RemoteDBA services!



view thread (226+ messages)  latest in thread

Message-ID: <87od674hy6.fsf@oxford.xeocode.com>
Permalink:  ../87od674hy6.fsf@oxford.xeocode.com/
Also on:    postgresql.org/message-id/87od674hy6.fsf@oxford.xeocode.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: stark@enterprisedb.com, tgl@sss.pgh.pa.us, alvherre@commandprompt.com, josh@agliodbs.com, heikki@enterprisedb.com, xzilla@users.sourceforge.net, peter_e@gmx.net, gsmith@gregsmith.com, pgadmin@pse-consulting.de, decibel@decibel.org
  Subject: Re: Overhauling GUCS
  In-Reply-To: <87od674hy6.fsf@oxford.xeocode.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox