pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
To: Tomas Vondra <tomas@vondra.me>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Michael Banck <mbanck@gmx.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Changing the state of data checksums in a running cluster
Date: Mon, 07 Oct 2024 19:42:31 +0100
Message-ID: <87r08rah60.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <642b8eeb-06ef-4aed-97a8-5297d9f67142@vondra.me>
References: <E07A611B-9CF3-4FDB-8CE8-A221E39040EC@yesql.se>
	<801a7cc1-bc23-4253-9b98-a5700f30e98e@enterprisedb.com>
	<383DA36E-405C-430E-A677-DB045EA37142@yesql.se>
	<66fb29a6.050a0220.1c8f2f.8be8@mx.google.com>
	<B136F620-E386-49BC-BE04-4CE49FB3D323@yesql.se>
	<8B317721-1CB7-4F82-B4DA-6B15AB1725D1@yesql.se>
	<642b8eeb-06ef-4aed-97a8-5297d9f67142@vondra.me>

Tomas Vondra <tomas@vondra.me> writes:

> 3) unnecessary ListCell in DataChecksumsWorkerMain() on line 1345,
>    shadowing earlier variable

All the ListCell variables can be eliminated by using the foreach_ptr
and foreach_oid macros instead of plain foreach.

- ilmari





view thread (162+ messages)  latest in thread

Message-ID: <87r08rah60.fsf@wibble.ilmari.org>
Permalink:  ../87r08rah60.fsf@wibble.ilmari.org/
Also on:    postgresql.org/message-id/87r08rah60.fsf@wibble.ilmari.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ilmari@ilmari.org, tomas@vondra.me, daniel@yesql.se, mbanck@gmx.net, pgsql-hackers@lists.postgresql.org
  Subject: Re: Changing the state of data checksums in a running cluster
  In-Reply-To: <87r08rah60.fsf@wibble.ilmari.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox