pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: David Gilman <dgilman@gilslotd.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Warn when parallel restoring a custom dump without data offsets
Date: Thu, 02 Jul 2020 17:25:21 -0400
Message-ID: <888847.1593725121@sss.pgh.pa.us> (raw)
In-Reply-To: <20200528003347.tut2sg2lhfb2i5xv@dar.local>
References: <20200519130740.GO18456@telsasoft.com>
	<CALBH9DDpO8dyttAx34_pu4dPXphm+k8Ca0ee+-1e7A+vXx4emQ@mail.gmail.com>
	<CAOaQA5xsa7KTsX3js5mt00Do+AiarQb5qd4ZYM3AR_NwXtFzeg@mail.gmail.com>
	<CALBH9DAmhfBw=VsKCcmig9jP2pBtuyLU5U5Tun_G=3ULs+q-dg@mail.gmail.com>
	<25161.1589986110@sss.pgh.pa.us>
	<CALBH9DBsWbwAXseNJdk4DbH1aR=sdczyAirp1aSxjpBSi86FzA@mail.gmail.com>
	<CALBH9DBYLxYxA7-=CZNa0K_Sg4wCv=RHFJDxOcSW8cZB5orezQ@mail.gmail.com>
	<20200523224751.GP4472@telsasoft.com>
	<20200525185429.6pp5vdvfu3vxlwac@dar.local>
	<20200525215526.t7dqywfywxzmlpbu@dar.local>
	<20200528003347.tut2sg2lhfb2i5xv@dar.local>

David Gilman <dgilman@gilslotd.com> writes:
> I've attached the latest patches after further review from Justin Pryzby.

I guess I'm completely confused about the purpose of these patches.
Far from coping with the situation of an unseekable file, they appear
to change pg_restore so that it fails altogether if it can't seek
its input file.  Why would we want to do this?

			regards, tom lane





view thread (18+ messages)  latest in thread

Message-ID: <888847.1593725121@sss.pgh.pa.us>
Permalink:  ../888847.1593725121@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/888847.1593725121@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dgilman@gilslotd.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Warn when parallel restoring a custom dump without data offsets
  In-Reply-To: <888847.1593725121@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox