pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Mikhail Titov <mlt@gmx.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [bug+patch] Inserting DEFAULT into generated columns from VALUES RTE
Date: Mon, 23 Nov 2020 11:16:21 -0500
Message-ID: <89193.1606148181@sss.pgh.pa.us> (raw)
In-Reply-To: <CAEZATCWSaNs9hihPBqxFqAQ-N0uqatPcPA118sUe9yxyEb4MTA@mail.gmail.com>
References: <9q0sgcr416t.fsf@gmx.us>
	<CAFj8pRC4Y2V3B0HjiPNcpwMfgd2Pj4bTJQJHtZuG=g2Nx5Puiw@mail.gmail.com>
	<9q0o8nd6lvx.fsf@gmx.us>
	<1501863.1599428560@sss.pgh.pa.us>
	<CAEZATCVaZNONSW1yEZsAe6U_-O0kqyPTv_N4_60ydd=ot7y79Q@mail.gmail.com>
	<1869094.1606078685@sss.pgh.pa.us>
	<CAEZATCWSaNs9hihPBqxFqAQ-N0uqatPcPA118sUe9yxyEb4MTA@mail.gmail.com>

Dean Rasheed <dean.a.rasheed@gmail.com> writes:
> On Sun, 22 Nov 2020 at 20:58, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> However, I think that just adjusting the error string would be
>> helpful, as attached.

> +1

>> (I'm also wondering why the second case is generic ERRCODE_SYNTAX_ERROR
>> and not ERRCODE_GENERATED_ALWAYS.  Didn't change it here, though.)

> I can't see any reason for it to be different, and
> ERRCODE_GENERATED_ALWAYS seems like the right code to use for both
> cases.

Sounds good to me; pushed that way.

			regards, tom lane





view thread (7+ messages)

Message-ID: <89193.1606148181@sss.pgh.pa.us>
Permalink:  ../89193.1606148181@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/89193.1606148181@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, dean.a.rasheed@gmail.com, mlt@gmx.us, pgsql-hackers@lists.postgresql.org
  Subject: Re: [bug+patch] Inserting DEFAULT into generated columns from VALUES RTE
  In-Reply-To: <89193.1606148181@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox