From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Alexey Bashtanov <bashtanov@imap.cc>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: log bind parameter values on error
Date: Thu, 3 Jan 2019 12:56:58 +0100
Message-ID: <896ac2ed-7735-1f24-d877-3249b38bb6fe@2ndquadrant.com> (raw)
In-Reply-To: <ad08f6a3-e38c-f851-a5a2-0bf68d1d7f72@imap.cc>
References: <0146a67b-a22a-0519-9082-bc29756b93a2@imap.cc>
<c4891f99-8385-5c31-1aac-e226356ec964@2ndquadrant.com>
<ad08f6a3-e38c-f851-a5a2-0bf68d1d7f72@imap.cc>
On 02/01/2019 23:53, Alexey Bashtanov wrote:
>> In fact, maybe don't use the Portal structure at all and just store the
>> saved textualized values inside postgres.c in a static variable.
>
> Unlike SQL, parameters may spend much more memory, so I'd have them
> in portal memory context to make sure the memory is released earlier
> rather than later.
Having them in the portal structure is different from having it in the
portal memory context. Although there is perhaps value in keeping them
together.
> Do you think it would be acceptable to leave them cached in parameters
> structure?
Let's see how it looks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, bashtanov@imap.cc
Subject: Re: log bind parameter values on error
In-Reply-To: <896ac2ed-7735-1f24-d877-3249b38bb6fe@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox