From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: TAP tests and symlinks on Windows
Date: Tue, 9 Jun 2020 09:28:04 +0200
Message-ID: <89a38304-8900-2e6b-de26-19a0312f3a87@2ndquadrant.com> (raw)
In-Reply-To: <20200609071931.GE38342@paquier.xyz>
References: <c50a646c-d9bb-7c62-a4bf-8256ff6ff338@2ndquadrant.com>
<20200609071931.GE38342@paquier.xyz>
On 2020-06-09 09:19, Michael Paquier wrote:
> On Mon, Jun 08, 2020 at 02:44:31PM +0200, Peter Eisentraut wrote:
>> both contain a TAP skip notice "symlinks not supported on Windows".
>>
>> This is untrue. Symlinks certainly work on Windows, and we have other TAP
>> tests using them, for example for tablespaces.
>
>> pg_rewind/t/004_pg_xlog_symlink.pl passes for me on Windows if I just remove
>> the skip stuff. My attached patch does that.
>
> What's the version of your perl installation on Windows? With 5.22, I
> am still seeing that symlink() is not implemented, causing the tests
> of pg_rewind to blow in flight with your patch (MSVC 2015 here).
I was using MSYS2 and the Perl version appears to have been 5.30.2.
Note sure which one of these two factors makes the difference.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz
Subject: Re: TAP tests and symlinks on Windows
In-Reply-To: <89a38304-8900-2e6b-de26-19a0312f3a87@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox