From: torikoshia <torikoshia@oss.nttdata.com>
To: Pgsql Hackers <pgsql-hackers@postgresql.org>
Subject: Should fix a comment referring to stats collector?
Date: Fri, 29 Jul 2022 22:05:56 +0900
Message-ID: <8a82417cdb6e8038fe276d4960e3207a@oss.nttdata.com> (raw)
Hi,
Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there
was a comment referring 'statistics collector' in pg_statistic.h.
> Note that since the arrays are variable-size, K may be chosen by the
> statistics collector.
Should it be modified to 'cumulative statistics system' like manual on
monitoring stats[1]?
Its title has changed from 'statistics collector' to 'cumulative
statistics system'.
[1] https://www.postgresql.org/docs/current/monitoring-stats.html
--
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATION
Attachments:v1-0001-Modified-a-comment-referring-to-stats-collector.patch (text/x-diff, 1.5K) download
From 5be784278e8e7aeeeadf60a772afccda7b59e6e4 Mon Sep 17 00:00:00 2001
From: Atsushi Torikoshi <torikoshia@oss.nttdata.com>
Date: Fri, 29 Jul 2022 21:34:15 +0900
Subject: [PATCH v1] Modified a comment referring to stats collector.
As statistics collector has been removed since 5891c7a8ed8f2d3d5,
comments refering to statistics collector should be modified to
cumulative statistics system.
---
src/include/catalog/pg_statistic.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/include/catalog/pg_statistic.h b/src/include/catalog/pg_statistic.hindex cdf7448139..d07fd2f93f 100644--- a/src/include/catalog/pg_statistic.h+++ b/src/include/catalog/pg_statistic.h@@ -178,9 +178,9 @@ DECLARE_FOREIGN_KEY((starelid, staattnum), pg_attribute, (attrelid, attnum));
* the K most common non-null values appearing in the column, and stanumbers
* contains their frequencies (fractions of total row count). The values
* shall be ordered in decreasing frequency. Note that since the arrays are
- * variable-size, K may be chosen by the statistics collector. Values should- * not appear in MCV unless they have been observed to occur more than once;- * a unique column will have no MCV slot.+ * variable-size, K may be chosen by the cumulative statistics system.+ * Values should not appear in MCV unless they have been observed to occur+ * more than once; a unique column will have no MCV slot.
*/
#define STATISTIC_KIND_MCV 1
base-commit: 59be1c942a47f6c8a4c47d242200fbbf4be59b88
--
2.27.0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: torikoshia@oss.nttdata.com
Subject: Re: Should fix a comment referring to stats collector?
In-Reply-To: <8a82417cdb6e8038fe276d4960e3207a@oss.nttdata.com>
References: <8a82417cdb6e8038fe276d4960e3207a@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox