pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
Should fix a comment referring to stats collector?
6+ messages / 5 participants
[nested] [flat]

Commits from this thread:
  2024-12-30 ebf2ab40e5  Remove redundant wording in pg_statistic.h
  2023-10-31 741ed2065c  C comment:  adjust statistics mention
* Should fix a comment referring to stats collector?
@ 2022-07-29 13:05 torikoshia <torikoshia@oss.nttdata.com>
  2022-07-29 17:53 ` Re: Should fix a comment referring to stats collector? Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 1 reply; 6+ messages in thread

From: torikoshia @ 2022-07-29 13:05 UTC (permalink / raw)
  To: pgsql-hackers

Hi,

Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there 
was a comment referring 'statistics collector' in pg_statistic.h.

>  Note that since the arrays are variable-size, K may be chosen by the 
> statistics collector.

Should it be modified to 'cumulative statistics system' like manual on 
monitoring stats[1]?
Its title has changed from 'statistics collector' to 'cumulative 
statistics system'.

[1] https://www.postgresql.org/docs/current/monitoring-stats.html

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION

Attachments:

v1-0001-Modified-a-comment-referring-to-stats-collector.patch (text/x-diff, 1.5K) download From 5be784278e8e7aeeeadf60a772afccda7b59e6e4 Mon Sep 17 00:00:00 2001 From: Atsushi Torikoshi <torikoshia@oss.nttdata.com> Date: Fri, 29 Jul 2022 21:34:15 +0900 Subject: [PATCH v1] Modified a comment referring to stats collector. As statistics collector has been removed since 5891c7a8ed8f2d3d5, comments refering to statistics collector should be modified to cumulative statistics system. --- src/include/catalog/pg_statistic.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/include/catalog/pg_statistic.h b/src/include/catalog/pg_statistic.h index cdf7448139..d07fd2f93f 100644 --- a/src/include/catalog/pg_statistic.h +++ b/src/include/catalog/pg_statistic.h @@ -178,9 +178,9 @@ DECLARE_FOREIGN_KEY((starelid, staattnum), pg_attribute, (attrelid, attnum)); * the K most common non-null values appearing in the column, and stanumbers * contains their frequencies (fractions of total row count). The values * shall be ordered in decreasing frequency. Note that since the arrays are - * variable-size, K may be chosen by the statistics collector. Values should - * not appear in MCV unless they have been observed to occur more than once; - * a unique column will have no MCV slot. + * variable-size, K may be chosen by the cumulative statistics system. + * Values should not appear in MCV unless they have been observed to occur + * more than once; a unique column will have no MCV slot. */ #define STATISTIC_KIND_MCV 1 base-commit: 59be1c942a47f6c8a4c47d242200fbbf4be59b88 -- 2.27.0
^ permalink raw reply [nested|flat] 6+ messages in thread

* Re: Should fix a comment referring to stats collector?
  2022-07-29 13:05 Should fix a comment referring to stats collector? torikoshia <torikoshia@oss.nttdata.com>
@ 2022-07-29 17:53 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-01 12:05   ` Re: Should fix a comment referring to stats collector? torikoshia <torikoshia@oss.nttdata.com>
  0 siblings, 1 reply; 6+ messages in thread

From: Alvaro Herrera @ 2022-07-29 17:53 UTC (permalink / raw)
  To: torikoshia <torikoshia@oss.nttdata.com>; +Cc: pgsql-hackers

On 2022-Jul-29, torikoshia wrote:

> Statistics collector has been removed since 5891c7a8ed8f2d3d5, but there was
> a comment referring 'statistics collector' in pg_statistic.h.
> 
> >  Note that since the arrays are variable-size, K may be chosen by the
> > statistics collector.
> 
> Should it be modified to 'cumulative statistics system' like manual on
> monitoring stats[1]?

I don't think this refers to the statistics collector process; I
understand it to refer to ANALYZE that captures the data being stored.
Maybe it should just say "K may be chosen at ANALYZE time".

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Nadie está tan esclavizado como el que se cree libre no siéndolo" (Goethe)





^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: Should fix a comment referring to stats collector?
  2022-07-29 13:05 Should fix a comment referring to stats collector? torikoshia <torikoshia@oss.nttdata.com>
  2022-07-29 17:53 ` Re: Should fix a comment referring to stats collector? Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2022-08-01 12:05   ` torikoshia <torikoshia@oss.nttdata.com>
  2023-10-31 15:02     ` Re: Should fix a comment referring to stats collector? Bruce Momjian <bruce@momjian.us>
  0 siblings, 1 reply; 6+ messages in thread

From: torikoshia @ 2022-08-01 12:05 UTC (permalink / raw)
  To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-hackers

On 2022-07-30 02:53, Alvaro Herrera wrote:

> I don't think this refers to the statistics collector process; I
> understand it to refer to ANALYZE that captures the data being stored.

Thanks for the explanation!

> Maybe it should just say "K may be chosen at ANALYZE time".

It seems clearer than current one.

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION





^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: Should fix a comment referring to stats collector?
  2022-07-29 13:05 Should fix a comment referring to stats collector? torikoshia <torikoshia@oss.nttdata.com>
  2022-07-29 17:53 ` Re: Should fix a comment referring to stats collector? Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-01 12:05   ` Re: Should fix a comment referring to stats collector? torikoshia <torikoshia@oss.nttdata.com>
@ 2023-10-31 15:02     ` Bruce Momjian <bruce@momjian.us>
  2024-12-28 07:25       ` Re: Should fix a comment referring to stats collector? Junwang Zhao <zhjwpku@gmail.com>
  0 siblings, 1 reply; 6+ messages in thread

From: Bruce Momjian @ 2023-10-31 15:02 UTC (permalink / raw)
  To: torikoshia <torikoshia@oss.nttdata.com>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; pgsql-hackers

On Mon, Aug  1, 2022 at 09:05:45PM +0900, torikoshia wrote:
> On 2022-07-30 02:53, Alvaro Herrera wrote:
> 
> > I don't think this refers to the statistics collector process; I
> > understand it to refer to ANALYZE that captures the data being stored.
> 
> Thanks for the explanation!
> 
> > Maybe it should just say "K may be chosen at ANALYZE time".
> 
> It seems clearer than current one.

Change made in master.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  Only you can decide what is important to you.





^ permalink  raw  reply  [nested|flat] 6+ messages in thread

* Re: Should fix a comment referring to stats collector?
  2022-07-29 13:05 Should fix a comment referring to stats collector? torikoshia <torikoshia@oss.nttdata.com>
  2022-07-29 17:53 ` Re: Should fix a comment referring to stats collector? Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-01 12:05   ` Re: Should fix a comment referring to stats collector? torikoshia <torikoshia@oss.nttdata.com>
  2023-10-31 15:02     ` Re: Should fix a comment referring to stats collector? Bruce Momjian <bruce@momjian.us>
@ 2024-12-28 07:25       ` Junwang Zhao <zhjwpku@gmail.com>
  2024-12-30 03:20         ` Re: Should fix a comment referring to stats collector? Michael Paquier <michael@paquier.xyz>
  0 siblings, 1 reply; 6+ messages in thread

From: Junwang Zhao @ 2024-12-28 07:25 UTC (permalink / raw)
  To: Bruce Momjian <bruce@momjian.us>; +Cc: torikoshia <torikoshia@oss.nttdata.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; pgsql-hackers

On Tue, Oct 31, 2023 at 11:02 PM Bruce Momjian <bruce@momjian.us> wrote:
>
> On Mon, Aug  1, 2022 at 09:05:45PM +0900, torikoshia wrote:
> > On 2022-07-30 02:53, Alvaro Herrera wrote:
> >
> > > I don't think this refers to the statistics collector process; I
> > > understand it to refer to ANALYZE that captures the data being stored.
> >
> > Thanks for the explanation!
> >
> > > Maybe it should just say "K may be chosen at ANALYZE time".
> >
> > It seems clearer than current one.
>
> Change made in master.

I believe some redundant wording has been committed.

K may be chosen may be chosen at ANALYZE time.

Attached patch fixes it and with some line adjustments.

>
> --
>   Bruce Momjian  <bruce@momjian.us>        https://momjian.us
>   EDB                                      https://enterprisedb.com
>
>   Only you can decide what is important to you.
>
>


-- 
Regards
Junwang Zhao

Attachments:

v1-0001-remove-redundant-wording-in-pg_statistic.h.patch (application/octet-stream, 1.3K) download From 4f2c1f3c1f137af391156194d179c80f18c0f97b Mon Sep 17 00:00:00 2001 From: Junwang Zhao <zhjwpku@gmail.com> Date: Sat, 28 Dec 2024 07:18:56 +0000 Subject: [PATCH v1] remove redundant wording in pg_statistic.h --- src/include/catalog/pg_statistic.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/include/catalog/pg_statistic.h b/src/include/catalog/pg_statistic.h index 041e626390..667782384e 100644 --- a/src/include/catalog/pg_statistic.h +++ b/src/include/catalog/pg_statistic.h @@ -183,9 +183,9 @@ DECLARE_FOREIGN_KEY((starelid, staattnum), pg_attribute, (attrelid, attnum)); * the K most common non-null values appearing in the column, and stanumbers * contains their frequencies (fractions of total row count). The values * shall be ordered in decreasing frequency. Note that since the arrays are - * variable-size, K may be chosen may be chosen at ANALYZE time. Values should - * not appear in MCV unless they have been observed to occur more than once; - * a unique column will have no MCV slot. + * variable-size, K may be chosen at ANALYZE time. Values should not appear + * in MCV unless they have been observed to occur more than once; a unique + * column will have no MCV slot. */ #define STATISTIC_KIND_MCV 1 -- 2.39.5
^ permalink raw reply [nested|flat] 6+ messages in thread

* Re: Should fix a comment referring to stats collector?
  2022-07-29 13:05 Should fix a comment referring to stats collector? torikoshia <torikoshia@oss.nttdata.com>
  2022-07-29 17:53 ` Re: Should fix a comment referring to stats collector? Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-08-01 12:05   ` Re: Should fix a comment referring to stats collector? torikoshia <torikoshia@oss.nttdata.com>
  2023-10-31 15:02     ` Re: Should fix a comment referring to stats collector? Bruce Momjian <bruce@momjian.us>
  2024-12-28 07:25       ` Re: Should fix a comment referring to stats collector? Junwang Zhao <zhjwpku@gmail.com>
@ 2024-12-30 03:20         ` Michael Paquier <michael@paquier.xyz>
  0 siblings, 0 replies; 6+ messages in thread

From: Michael Paquier @ 2024-12-30 03:20 UTC (permalink / raw)
  To: Junwang Zhao <zhjwpku@gmail.com>; +Cc: Bruce Momjian <bruce@momjian.us>; torikoshia <torikoshia@oss.nttdata.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; pgsql-hackers

On Sat, Dec 28, 2024 at 03:25:46PM +0800, Junwang Zhao wrote:
> I believe some redundant wording has been committed.
> 
> K may be chosen may be chosen at ANALYZE time.
> 
> Attached patch fixes it and with some line adjustments.

Indeed.  Fixed, thanks!
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

^ permalink  raw  reply  [nested|flat] 6+ messages in thread


end of thread, other threads:[~2024-12-30 03:20 UTC | newest]

Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-07-29 13:05 Should fix a comment referring to stats collector? torikoshia <torikoshia@oss.nttdata.com>
2022-07-29 17:53 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-08-01 12:05   ` torikoshia <torikoshia@oss.nttdata.com>
2023-10-31 15:02     ` Bruce Momjian <bruce@momjian.us>
2024-12-28 07:25       ` Junwang Zhao <zhjwpku@gmail.com>
2024-12-30 03:20         ` Michael Paquier <michael@paquier.xyz>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox