pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedTypo in insert.sgml
8+ messages / 5 participants
[nested] [flat]
* Typo in insert.sgml
@ 2017-06-18 07:16 Julien Rouhaud <julien.rouhaud@dalibo.com>
2017-06-20 18:34 ` Re: Typo in insert.sgml Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 1 reply; 8+ messages in thread
From: Julien Rouhaud @ 2017-06-18 07:16 UTC (permalink / raw)
To: pgsql-hackers
Patch attached.
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org
diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml
index 94dad00870..0e327e5b2e 100644
--- a/doc/src/sgml/ref/insert.sgml
+++ b/doc/src/sgml/ref/insert.sgml
@@ -228,7 +228,7 @@ INSERT INTO <replaceable class="PARAMETER">table_name</replaceable> [ AS <replac
Writing <literal>INSERT INTO tbl2 OVERRIDING USER VALUE SELECT * FROM
tbl1</literal> will copy from <literal>tbl1</literal> all columns that
are not identity columns in <literal>tbl2</literal> but will continue
- the sequence counters for any identity columns.
+ to use the sequence counters for any identity columns.
</para>
</listitem>
</varlistentry>
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Attachments:
[text/plain] fix_insert_sgml-1.diff (695B, ../../20170618071607.GA16418@nol.local/2-fix_insert_sgml-1.diff)
download | inline diff:
diff --git a/doc/src/sgml/ref/insert.sgml b/doc/src/sgml/ref/insert.sgml
index 94dad00870..0e327e5b2e 100644
--- a/doc/src/sgml/ref/insert.sgml
+++ b/doc/src/sgml/ref/insert.sgml
@@ -228,7 +228,7 @@ INSERT INTO <replaceable class="PARAMETER">table_name</replaceable> [ AS <replac
Writing <literal>INSERT INTO tbl2 OVERRIDING USER VALUE SELECT * FROM
tbl1</literal> will copy from <literal>tbl1</literal> all columns that
are not identity columns in <literal>tbl2</literal> but will continue
- the sequence counters for any identity columns.
+ to use the sequence counters for any identity columns.
</para>
</listitem>
</varlistentry>
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Typo in insert.sgml
2017-06-18 07:16 Typo in insert.sgml Julien Rouhaud <julien.rouhaud@dalibo.com>
@ 2017-06-20 18:34 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-06-20 18:42 ` Re: Typo in insert.sgml Robert Haas <robertmhaas@gmail.com>
2017-06-20 18:48 ` Re: Typo in insert.sgml Julien Rouhaud <julien.rouhaud@dalibo.com>
0 siblings, 2 replies; 8+ messages in thread
From: Peter Eisentraut @ 2017-06-20 18:34 UTC (permalink / raw)
To: Julien Rouhaud <julien.rouhaud@dalibo.com>; pgsql-hackers
On 6/18/17 03:16, Julien Rouhaud wrote:
> Patch attached.
This was not a typo, this was intentional.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Typo in insert.sgml
2017-06-18 07:16 Typo in insert.sgml Julien Rouhaud <julien.rouhaud@dalibo.com>
2017-06-20 18:34 ` Re: Typo in insert.sgml Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
@ 2017-06-20 18:42 ` Robert Haas <robertmhaas@gmail.com>
2017-06-20 19:03 ` Re: Typo in insert.sgml David G. Johnston <david.g.johnston@gmail.com>
2017-06-20 20:35 ` Re: Typo in insert.sgml Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 2 replies; 8+ messages in thread
From: Robert Haas @ 2017-06-20 18:42 UTC (permalink / raw)
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; +Cc: Julien Rouhaud <julien.rouhaud@dalibo.com>; pgsql-hackers
On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
<peter.eisentraut@2ndquadrant.com> wrote:
> On 6/18/17 03:16, Julien Rouhaud wrote:
>> Patch attached.
>
> This was not a typo, this was intentional.
To me, Julien's change seems to make it easier to understand, but
maybe I'm misunderstanding what it's trying to say in the first place.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Typo in insert.sgml
2017-06-18 07:16 Typo in insert.sgml Julien Rouhaud <julien.rouhaud@dalibo.com>
2017-06-20 18:34 ` Re: Typo in insert.sgml Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-06-20 18:42 ` Re: Typo in insert.sgml Robert Haas <robertmhaas@gmail.com>
@ 2017-06-20 19:03 ` David G. Johnston <david.g.johnston@gmail.com>
2017-08-28 01:34 ` Re: Typo in insert.sgml Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
1 sibling, 1 reply; 8+ messages in thread
From: David G. Johnston @ 2017-06-20 19:03 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; Julien Rouhaud <julien.rouhaud@dalibo.com>; pgsql-hackers
On Tuesday, June 20, 2017, Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com <javascript:;>> wrote:
> > On 6/18/17 03:16, Julien Rouhaud wrote:
> >> Patch attached.
> >
> > This was not a typo, this was intentional.
>
> To me, Julien's change seems to make it easier to understand, but
> maybe I'm misunderstanding what it's trying to say in the first place.
>
>
Maybe
[...] that are not identity columns in <literal>tbl2</literal>. Values for
identity columns will come from the sequence generators for
<literal>tbl2</literal>.
Otherwise I'd drop the word "continue" altogether and just say "but will
use the sequence counters for".
David J.
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Typo in insert.sgml
2017-06-18 07:16 Typo in insert.sgml Julien Rouhaud <julien.rouhaud@dalibo.com>
2017-06-20 18:34 ` Re: Typo in insert.sgml Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-06-20 18:42 ` Re: Typo in insert.sgml Robert Haas <robertmhaas@gmail.com>
2017-06-20 19:03 ` Re: Typo in insert.sgml David G. Johnston <david.g.johnston@gmail.com>
@ 2017-08-28 01:34 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 0 replies; 8+ messages in thread
From: Peter Eisentraut @ 2017-08-28 01:34 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; Robert Haas <robertmhaas@gmail.com>; +Cc: Julien Rouhaud <julien.rouhaud@dalibo.com>; pgsql-hackers
On 6/20/17 15:03, David G. Johnston wrote:
> On Tuesday, June 20, 2017, Robert Haas <robertmhaas@gmail.com
> <mailto:robertmhaas@gmail.com>> wrote:
>
> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com <javascript:;>> wrote:
> > On 6/18/17 03:16, Julien Rouhaud wrote:
> >> Patch attached.
> >
> > This was not a typo, this was intentional.
>
> To me, Julien's change seems to make it easier to understand, but
> maybe I'm misunderstanding what it's trying to say in the first place.
>
>
> Maybe
>
> [...] that are not identity columns in <literal>tbl2</literal>. Values
> for identity columns will come from the sequence generators for
> <literal>tbl2</literal>.
>
> Otherwise I'd drop the word "continue" altogether and just say "but will
> use the sequence counters for".
I have committed something along those lines.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Typo in insert.sgml
2017-06-18 07:16 Typo in insert.sgml Julien Rouhaud <julien.rouhaud@dalibo.com>
2017-06-20 18:34 ` Re: Typo in insert.sgml Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-06-20 18:42 ` Re: Typo in insert.sgml Robert Haas <robertmhaas@gmail.com>
@ 2017-06-20 20:35 ` Tom Lane <tgl@sss.pgh.pa.us>
2017-06-20 20:58 ` Re: Typo in insert.sgml David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 1 reply; 8+ messages in thread
From: Tom Lane @ 2017-06-20 20:35 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; Julien Rouhaud <julien.rouhaud@dalibo.com>; pgsql-hackers
Robert Haas <robertmhaas@gmail.com> writes:
> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> This was not a typo, this was intentional.
> To me, Julien's change seems to make it easier to understand, but
> maybe I'm misunderstanding what it's trying to say in the first place.
I think there are two subtly different things here: the sequence counters
will continue to be attached to the identity columns, and the counters
will continue in sequence (ie, no implied ALTER SEQUENCE RESTART).
The existing text seems to mean the latter but Julien's change makes it
about the former.
It could use rewording for clarity, just not this rewording.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Typo in insert.sgml
2017-06-18 07:16 Typo in insert.sgml Julien Rouhaud <julien.rouhaud@dalibo.com>
2017-06-20 18:34 ` Re: Typo in insert.sgml Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-06-20 18:42 ` Re: Typo in insert.sgml Robert Haas <robertmhaas@gmail.com>
2017-06-20 20:35 ` Re: Typo in insert.sgml Tom Lane <tgl@sss.pgh.pa.us>
@ 2017-06-20 20:58 ` David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 8+ messages in thread
From: David G. Johnston @ 2017-06-20 20:58 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Robert Haas <robertmhaas@gmail.com>; Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; Julien Rouhaud <julien.rouhaud@dalibo.com>; pgsql-hackers
On Tue, Jun 20, 2017 at 1:35 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> On Tue, Jun 20, 2017 at 2:34 PM, Peter Eisentraut
>> <peter.eisentraut@2ndquadrant.com> wrote:
>>> This was not a typo, this was intentional.
>
>> To me, Julien's change seems to make it easier to understand, but
>> maybe I'm misunderstanding what it's trying to say in the first place.
>
> I think there are two subtly different things here: the sequence counters
> will continue to be attached to the identity columns, and the counters
> will continue in sequence (ie, no implied ALTER SEQUENCE RESTART).
> The existing text seems to mean the latter but Julien's change makes it
> about the former.
>
> It could use rewording for clarity, just not this rewording.
Tom, I'm not following your train of thought:
Given one sequenced IDENTITY column in each table (some rows were
delete from each already):
tbl1
4
5
6
tbl2
10
11
12
The point being made is that inserting all rows from tbl1 into tbl2
will result in tbl2 having:
10
11
12
13
14
15
and not:
10
11
12
4
5
6
That the sequence counters continue to be attached seems like it can
and should be taken for granted. Inserting to a table likewise should
never cause an ALTER SEQUENCE RESTART to occur and so can and should
be taken for granted.
ISTM that both the existing text and Julien's variation say this, just
differently. I think the word "continue" is part of the problem. I
also think not being explicit about the fact that its tbl2's sequence
that supplies the new values - instead of using the values already
present in tbl1 - requires one to think harder about the scenario than
need be.
David J.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: Typo in insert.sgml
2017-06-18 07:16 Typo in insert.sgml Julien Rouhaud <julien.rouhaud@dalibo.com>
2017-06-20 18:34 ` Re: Typo in insert.sgml Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
@ 2017-06-20 18:48 ` Julien Rouhaud <julien.rouhaud@dalibo.com>
1 sibling, 0 replies; 8+ messages in thread
From: Julien Rouhaud @ 2017-06-20 18:48 UTC (permalink / raw)
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>; pgsql-hackers
On 20/06/2017 20:34, Peter Eisentraut wrote:
> On 6/18/17 03:16, Julien Rouhaud wrote:
>> Patch attached.
>
> This was not a typo, this was intentional.
>
Oh, sorry. I'm not a native english speaker, that sounded really weird.
--
Julien Rouhaud
http://dalibo.com - http://dalibo.org
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2017-08-28 01:34 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-06-18 07:16 Typo in insert.sgml Julien Rouhaud <julien.rouhaud@dalibo.com>
2017-06-20 18:34 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-06-20 18:42 ` Robert Haas <robertmhaas@gmail.com>
2017-06-20 19:03 ` David G. Johnston <david.g.johnston@gmail.com>
2017-08-28 01:34 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-06-20 20:35 ` Tom Lane <tgl@sss.pgh.pa.us>
2017-06-20 20:58 ` David G. Johnston <david.g.johnston@gmail.com>
2017-06-20 18:48 ` Julien Rouhaud <julien.rouhaud@dalibo.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox