pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Joshua D. Drake <jd@commandprompt.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: David Steele <david@pgmasters.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)
Date: Wed, 22 Aug 2018 20:16:24 -0400
Message-ID: <9102.1534983384@sss.pgh.pa.us> (raw)
In-Reply-To: <20180823000905.fjthfohmczss4fiw@alap3.anarazel.de>
References: <97d4b165-192d-3605-749c-f614a0c4e783@2ndquadrant.com>
	<20532.1534872560@sss.pgh.pa.us>
	<20180821173123.wliiykscjvtnbxk2@alap3.anarazel.de>
	<bc329070-e3b4-cc10-1502-818e600a5648@2ndQuadrant.com>
	<1d5946a3-aa85-a3ec-c8aa-b3e9b66dd5d9@commandprompt.com>
	<20180821204936.tqdmjolkoo2sv5og@alap3.anarazel.de>
	<303572b3-89a5-6177-d46a-e23b2b4d6caa@2ndQuadrant.com>
	<20180821232952.ixj6kgccoqcjp5gf@alap3.anarazel.de>
	<CANFyU94+wn2iN_ry=2SZFzxdFP6vAHA2+K0uhyyCS4YQWyyrxw@mail.gmail.com>
	<20180822120211.prl6uxspai4lahfs@alap3.anarazel.de>
	<20180823000905.fjthfohmczss4fiw@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> There's a few further potential cleanups due to relying on c99:
> - Use __func__ unconditionally, rather than having configure test for it
> - Use inline unconditionally, rather than having configure test for it
> - Remove tests for AC_TYPE_INTPTR_T, AC_TYPE_UINTPTR_T,
>   AC_TYPE_LONG_LONG_INT, we can rely on them being present.
> - probably more in that vein

I wouldn't be in too much of a hurry to do that, particularly not the
third item.  You are confusing "compiler is c99" with "system headers
are c99".  Moreover, I don't see that we're buying much with such
changes.

			regards, tom lane




view thread (37+ messages)  latest in thread

Message-ID: <9102.1534983384@sss.pgh.pa.us>
Permalink:  ../9102.1534983384@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/9102.1534983384@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, sandeep.thakkar@enterprisedb.com, andrew.dunstan@2ndquadrant.com, jd@commandprompt.com, peter.eisentraut@2ndquadrant.com, thomas.munro@enterprisedb.com, david@pgmasters.net, pgsql-hackers@lists.postgresql.org, craig@2ndquadrant.com
  Subject: Re: Windows vs C99 (was Re: C99 compliance for src/port/snprintf.c)
  In-Reply-To: <9102.1534983384@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox