public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: make pg_createsubscriber option names more consistent
Date: Thu, 1 Aug 2024 12:32:14 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <TYAPR01MB5692A9A7D689CA2F1F51DE06F5B12@TYAPR01MB5692.jpnprd01.prod.outlook.com>
References: <[email protected]>
	<TYAPR01MB5692A9A7D689CA2F1F51DE06F5B12@TYAPR01MB5692.jpnprd01.prod.outlook.com>

On 31.07.24 11:15, Hayato Kuroda (Fujitsu) wrote:
> Dear Peter,
> 
>> I propose to rename the pg_createsubscriber option --socket-directory to
>> --socketdir.  This would make it match the equivalent option in
>> pg_upgrade.  (It even has the same short option '-s'.)
>> pg_createsubscriber and pg_upgrade have a lot of common terminology and
>> a similar operating mode, so it would make sense to keep this consistent.
> 
> +1. If so, should we say "default current dir." instead of "default current directory" in usage()
> because pg_upgrade says like that?

Committed with that change.  Thanks.

view thread (2+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: make pg_createsubscriber option names more consistent
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox