pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: David Fetter <david@fetter.org>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: PostgreSQL Development <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v5] Show detailed table persistence in \dt+
Date: Wed, 03 Jul 2019 11:49:30 -0400
Message-ID: <9395.1562168970@sss.pgh.pa.us> (raw)
In-Reply-To: <FBBB931F-3A55-42A4-BCD4-C8BC5143E969@yesql.se>
References: <20190702203526.GA29015@alvherre.pgsql>
	<FBBB931F-3A55-42A4-BCD4-C8BC5143E969@yesql.se>

Daniel Gustafsson <daniel@yesql.se> writes:
>> On 2 Jul 2019, at 22:35, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
>> Anyway I'm not objecting to the patch -- I agree that we're already not
>> testing translatability and that this patch shouldn't be forced to start
>> doing it.

> I forgot to add that to my previous email, the patch as it stands in v8 looks
> good to me. I’ve missed having this on many occasions.

OK, pushed.

For the record, I did verify that the translatability logic worked
by adding some bogus entries to psql/po/es.po and seeing that the
display changed to match.

			regards, tom lane





view thread (19+ messages)

Message-ID: <9395.1562168970@sss.pgh.pa.us>
Permalink:  ../9395.1562168970@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/9395.1562168970@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, daniel@yesql.se, alvherre@2ndquadrant.com, david@fetter.org, coelho@cri.ensmp.fr, rafia.pghackers@gmail.com
  Subject: Re: [PATCH v5] Show detailed table persistence in \dt+
  In-Reply-To: <9395.1562168970@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox