From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <jcnaylor@gmail.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Stas Kelvich <s.kelvich@postgrespro.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: unused_oids script is broken with bsd sed
Date: Wed, 25 Apr 2018 14:26:35 -0400
Message-ID: <9426.1524680795@sss.pgh.pa.us> (raw)
In-Reply-To: <CAJVSVGUqEPFWxRSB0pxO5jHR83O2HF6n9Dhv51kLQuwdkuxTHQ@mail.gmail.com>
References: <37D774E4-FE1F-437E-B3D2-593F314B7505@postgrespro.ru>
<34a54c54-9132-1254-2bc3-d3489fb79728@2ndQuadrant.com>
<4473.1524665917@sss.pgh.pa.us>
<CAJVSVGUqEPFWxRSB0pxO5jHR83O2HF6n9Dhv51kLQuwdkuxTHQ@mail.gmail.com>
John Naylor <jcnaylor@gmail.com> writes:
> On 4/25/18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I think we should rewrite
>> both of them to use the Catalog.pm infrastructure.
> If we're going to use Catalog.pm for that, it seems more convenient to
> expose toast and index oids directly rather than in strings formatted
> specifically for the bki file, as in the attached. Thoughts?
Good idea, I like this better than what Stas did in his patch.
I'm a bit inclined to preserve the old variable names (toast_name,
toast_oid etc) as the hash keys because they seem more greppable
than the generic "oid", "name" that you have here. But maybe that
isn't an interesting consideration.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, jcnaylor@gmail.com, andrew.dunstan@2ndquadrant.com, s.kelvich@postgrespro.ru
Subject: Re: unused_oids script is broken with bsd sed
In-Reply-To: <9426.1524680795@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox