pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: ICU integration
Date: Thu, 16 Feb 2017 08:15:46 -0500
Message-ID: <94ac0476-e449-4cc0-d4bd-76d39576979d@2ndquadrant.com> (raw)
In-Reply-To: <CAH2-Wzkt_bf5yBeoNMB95NG40tg_UNNvCpYLzhmAoNijG3LMPA@mail.gmail.com>
References: <85364fde-091f-bbc0-fec2-e3ede39840a6@2ndquadrant.com>
	<3a88fa29-275b-f547-9957-86d4b2cd68db@2ndquadrant.com>
	<CAM3SWZT6YFtkkjUOGgzBV9_tMijz+s68YgDZi7Qc2sPdFnQ9Bw@mail.gmail.com>
	<CAEepm=3W4kUoAMYG3XOKPqv-=k1TL5A8zJvF6M93DNaHRoQeyw@mail.gmail.com>
	<c288b52e-2b83-8c0c-0f99-b34531763a5a@2ndquadrant.com>
	<CAH2-Wzkt_bf5yBeoNMB95NG40tg_UNNvCpYLzhmAoNijG3LMPA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 2/16/17 01:13, Peter Geoghegan wrote:
> On Wed, Feb 15, 2017 at 9:17 PM, Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> I have changed it to use ucol_nextSortKeyPart() when appropriate.
> 
> I think it would be fine if the second last argument was
> "sizeof(Datum)", not "Min(sizeof(Datum), sss->buflen2)" here:

I don't see anything that guarantees that the buffer length is always at
least sizeof(Datum).

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (83+ messages)  latest in thread

Message-ID: <94ac0476-e449-4cc0-d4bd-76d39576979d@2ndquadrant.com>
Permalink:  ../94ac0476-e449-4cc0-d4bd-76d39576979d@2ndquadrant.com/
Also on:    postgresql.org/message-id/94ac0476-e449-4cc0-d4bd-76d39576979d@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, pg@bowt.ie, thomas.munro@enterprisedb.com
  Subject: Re: ICU integration
  In-Reply-To: <94ac0476-e449-4cc0-d4bd-76d39576979d@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox