pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Мельников Антон Андреевич <aamelnikov@inbox.ru>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: installcheck fails when compute_query_id=on or pg_stat_statsement is loaded
Date: Fri, 15 Oct 2021 09:46:18 -0400
Message-ID: <952792.1634305578@sss.pgh.pa.us> (raw)
In-Reply-To: <CAOBaU_b57L=NxBaOEGHZ2M35LYZKsLu2YkekhB7yZ4=CrGo+cA@mail.gmail.com>
References: <1634283396.372373993@f75.i.mail.ru>
	<CAOBaU_b57L=NxBaOEGHZ2M35LYZKsLu2YkekhB7yZ4=CrGo+cA@mail.gmail.com>

Julien Rouhaud <rjuju123@gmail.com> writes:
> ... Note that you don't really need to enable
> pg_stat_statements, enabling compute_query_id is enough.  The query
> identifier is only displayed for EXPLAIN (VERBOSE), so it's already a
> bit filtered.  I don't see any simple way to entirely avoid the
> problem though.

> There are already many options that can break the regression tests, so
> maybe it's ok to accept that this is yet another one.

Yeah, that's my reaction.  We could add "compute_query_id = off" to
the database-level settings set up by pg_regress, but that cure seems
worse than the disease.  It would make it impossible to run the
regression tests with pg_stat_statements loaded, which you might wish
to do (just ignoring the bogus test failures) as a way of testing
pg_stat_statements.

			regards, tom lane





view thread (3+ messages)

Message-ID: <952792.1634305578@sss.pgh.pa.us>
Permalink:  ../952792.1634305578@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/952792.1634305578@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, rjuju123@gmail.com, aamelnikov@inbox.ru
  Subject: Re: installcheck fails when compute_query_id=on or pg_stat_statsement is loaded
  In-Reply-To: <952792.1634305578@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox