From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Upgrading pg_statistic to handle collation honestly
Date: Fri, 14 Dec 2018 09:57:57 -0500
Message-ID: <9576.1544799477@sss.pgh.pa.us> (raw)
In-Reply-To: <106ec7b1-83c4-4fba-f10a-d0213fe19694@2ndquadrant.com>
References: <14706.1544630227@sss.pgh.pa.us>
<106ec7b1-83c4-4fba-f10a-d0213fe19694@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 12/12/2018 16:57, Tom Lane wrote:
>> + stats->attrcollid = exprCollation(index_expr);
>> + /* XXX should we consult indcollation instead? */
> After looking through this again, I think the answer here is "yes".
Yeah, I was leaning towards that as well, but hadn't written the extra
code needed to make it so. Will fix.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Upgrading pg_statistic to handle collation honestly
In-Reply-To: <9576.1544799477@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox