pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Drouvot, Bertrand <bdrouvot@amazon.com>
To: Michael Paquier <michael@paquier.xyz>
To: Jeremy Schneider <schnjere@amazon.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Imseih (AWS), Sami <simseih@amazon.com>
Subject: Re: [PATCH] Query Jumbling for CALL and SET utility statements
Date: Thu, 8 Sep 2022 08:49:13 +0200
Message-ID: <95c702fa-61a1-1bc1-7313-4f2b46fdaf94@amazon.com> (raw)
In-Reply-To: <Yxl8R8mAUG2vqAcC@paquier.xyz>
References: <36e5bffe-e989-194f-85c8-06e7bc88e6f7@amazon.com>
	<20220831160839.wseeotr7rckucpmv@awork3.anarazel.de>
	<46ca04f9-1e37-c862-9a28-c5dffaee412f@amazon.com>
	<20220831190604.l2luuhj3xkau7dvk@awork3.anarazel.de>
	<e43a0e02-4ef4-d510-a00a-cf39d2a9df19@amazon.com>
	<cbd28368-a5ae-f141-4c3f-28ba9f608ba0@amazon.com>
	<BBB9A13D-BBE2-44A4-9CA7-6E189120E5A2@amazon.com>
	<09c04aba-7f12-e524-20f7-3f92c1479fdf@amazon.com>
	<9aee54f2-5cc1-5b64-1f73-6961932e7bd2@amazon.com>
	<Yxl8R8mAUG2vqAcC@paquier.xyz>

Hi,

On 9/8/22 7:23 AM, Michael Paquier wrote:
> On Wed, Sep 07, 2022 at 06:19:42PM -0700, Jeremy Schneider wrote:
>> I didn't fully debug yet, but here's the backtrace on my 14.4 build with
>> the patch

Thanks Jeremy for reporting the issue!

> What happens on HEAD?  That would be the target branch for a new
> feature.

Just tested and i can see the same issue on HEAD.

Issue is on stmt->name being NULL here:

Breakpoint 2, JumbleExpr (jstate=0x55d60e769e30, node=0x55d60e769b60) at 
queryjumble.c:364
364             if (node == NULL)
(gdb) n
368             check_stack_depth();
(gdb)
374             APP_JUMB(node->type);
(gdb)
376             switch (nodeTag(node))
(gdb)
398                                     VariableSetStmt *stmt = 
(VariableSetStmt *) node;
(gdb) n
400 APP_JUMB_STRING(stmt->name);
(gdb) p stmt->name
$1 = 0x0

I'll have a closer look.

Regards,

-- 

Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services:https://aws.amazon.com

view thread (45+ messages)  latest in thread

Message-ID: <95c702fa-61a1-1bc1-7313-4f2b46fdaf94@amazon.com>
Permalink:  ../95c702fa-61a1-1bc1-7313-4f2b46fdaf94@amazon.com/
Also on:    postgresql.org/message-id/95c702fa-61a1-1bc1-7313-4f2b46fdaf94@amazon.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bdrouvot@amazon.com, michael@paquier.xyz, schnjere@amazon.com, pgsql-hackers@lists.postgresql.org, pavel.stehule@gmail.com, andres@anarazel.de, simseih@amazon.com
  Subject: Re: [PATCH] Query Jumbling for CALL and SET utility statements
  In-Reply-To: <95c702fa-61a1-1bc1-7313-4f2b46fdaf94@amazon.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox