pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Noah Misch <noah@leadboat.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: AIX support - alignment issues
Date: Sat, 02 Jul 2022 17:31:54 -0400
Message-ID: <985075.1656797514@sss.pgh.pa.us> (raw)
In-Reply-To: <20220702205149.k5qp42n2ztuuhui2@alap3.anarazel.de>
References: <20220702183354.a6uhja35wta7agew@alap3.anarazel.de>
	<CAH2-WzndKXQQGh-7sCOTKL_87Kt918r0F2ztTAraeBCAC8v3OQ@mail.gmail.com>
	<968410.1656789743@sss.pgh.pa.us>
	<CAH2-WzmnoGPN--Z7MfTqv2TTVLJF0Y0tzZbGUS-NAwJ0wv15hw@mail.gmail.com>
	<977853.1656794075@sss.pgh.pa.us>
	<20220702205149.k5qp42n2ztuuhui2@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> What made me look at this issue right now is that the alignment issue lead the
> 56bit relfilenode patch to move the relfilenode field to the start of pg_class
> (ahead of the oid),

Agreed, up with that we should not put.  However ...

> because a 64bit value cannot be after a NameData.

... this coding rule strikes me as utterly ridiculous.  Why can't we
instead insist that NAMEDATALEN must be a multiple of 8?  Anyone who
tries to make it different from that is likely to be wasting padding
space even on platforms where there's not a deeper problem.

			regards, tom lane

view thread (48+ messages)  latest in thread

Message-ID: <985075.1656797514@sss.pgh.pa.us>
Permalink:  ../985075.1656797514@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/985075.1656797514@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, pg@bowt.ie, noah@leadboat.com
  Subject: Re: AIX support - alignment issues
  In-Reply-To: <985075.1656797514@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox