From: e.indrupskaya@postgrespro.ru
To: Amit Langote <amitlangote09@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Andrew Dunstan <andrew@dunslane.net>
Subject: Re: SQL/JSON revisited
Date: Mon, 20 Feb 2023 12:47:54 +0300
Message-ID: <987a46a8-5a15-cd5c-0ef3-cfd94f15bd61@postgrespro.ru> (raw)
In-Reply-To: <CA+HiwqEgGJsdb4keqbXHUEtsRiNf8UAEqBQQe6k=98AkGGG0gQ@mail.gmail.com>
References: <CA+HiwqHROpf9e644D8BRqYvaAPmgBZVup-xKMDPk-nd4EpgzHw@mail.gmail.com>
<CA+HiwqE9aeaOTvTZ4xP37ieS2TN6WsV2MrSha2qtzsF8gV229w@mail.gmail.com>
<CALDaNm1b8NZgxSESw2u5GNcDbMNGnXujN7f-XxUL506hXert5g@mail.gmail.com>
<CA+HiwqEmsVHC23fry0S9T_3ZNsT=6R25vi2DEkE9s3wDskic_w@mail.gmail.com>
<CA+HiwqEgGJsdb4keqbXHUEtsRiNf8UAEqBQQe6k=98AkGGG0gQ@mail.gmail.com>
Hi Amit and Andrew,
Regarding not squashing [PATCH v3 11/11] Proposed reworking of
SQL/JSON documentaion, here is exactly what Tom Lane wrote in the comment to commit 47046763c3:
Use <parameter>
consistently for things that are in fact names of parameters (including
OUT parameters), reserving <replaceable> for things that aren't.
Following this, <parameter> tags should be replaced with <replaceable> because
the SQL/JSON functions' code does not explicitly specify those tagged variables
as function parameters. Doesn't it convince you to look at the patch again? Thank you.
On 20.02.2023 10:35, Amit Langote wrote:
>> no parameter names in the functions' code either
> Hi,
>
> On Mon, Jan 30, 2023 at 3:39 PM Amit Langote <amitlangote09@gmail.com> wrote:
>> On Fri, Jan 27, 2023 at 11:27 PM vignesh C <vignesh21@gmail.com> wrote:
>>> On Tue, 17 Jan 2023 at 19:01, Amit Langote <amitlangote09@gmail.com> wrote:
>>>> And I've just finished doing that. In the attached updated 0004,
>>>> which adds the JsonExpr node, its evaluation code is now broken into
>>>> ExprEvalSteps to handle the subsidiary JsonCoercion and JsonBehavior
>>>> expression nodes that previously used ExprState for recursive
>>>> evaluation. Andres didn't like the latter as previously discussed at
>>>> [1].
>>>>
>>>> I've also attached the patch that Elena has proposed as the patch
>>>> 0011. I haven't managed to review it yet, though once I do, I'll
>>>> merge it into the main documentation patch 0009. Thanks Elena.
>>> The patch does not apply on top of HEAD as in [1], please post a rebased patch:
>> Thanks for the heads up. Here's a rebased version.
> Rebased again over queryjumble overhaul.
>
> I decided to squash what was "[PATCH v3 01/11] Common SQL/JSON
> clauses" into "[PATCH v3 02/11] SQL/JSON constructors", because I
> noticed "useless productions" warnings against its gram.y additions
> when building just 0001.
>
> I also looked at squashing "[PATCH v3 11/11] Proposed reworking of
> SQL/JSON documentaion" into "[PATCH v3 09/11] Documentation for
> SQL/JSON features", but didn't, again, because I am still not sure
> which one of <parameter> and <replaceable> is correct for the SQL/JSON
> function constructs. Maybe it's the latter looking at the markup for
> some text on [1], such as exists ( path_expression ) → boolean, but
> Andrew sounded doubtful about that upthread.
>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: e.indrupskaya@postgrespro.ru, amitlangote09@gmail.com, vignesh21@gmail.com, andrew@dunslane.net
Subject: Re: SQL/JSON revisited
In-Reply-To: <987a46a8-5a15-cd5c-0ef3-cfd94f15bd61@postgrespro.ru>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox