pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Vik Fearing <vik@postgresfriends.org>
To: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Clean up optional rules in grammar
Date: Wed, 11 Nov 2020 13:40:31 +0100
Message-ID: <98ddbd3e-392e-589e-40a7-643111ce03f1@enterprisedb.com> (raw)
In-Reply-To: <0e608c89-3b1d-1dbf-7c03-423f15dcbbed@postgresfriends.org>
References: <e9eed669-e32d-6919-fed4-acc0daea857b@enterprisedb.com>
	<0e608c89-3b1d-1dbf-7c03-423f15dcbbed@postgresfriends.org>

On 2020-11-11 12:43, Vik Fearing wrote:
> No objections, but could we also take this opportunity to standardize
> the comment itself?  Even in your patch there is a mix of spacing and
> casing.
> 
> My preference is /* EMPTY */.  That is, uppercase with spaces, but
> whatever gets chosen is fine with me.

Looks like /*EMPTY*/ is the most common right now.  I agree this should 
be straightened out.





view thread (6+ messages)  latest in thread

Message-ID: <98ddbd3e-392e-589e-40a7-643111ce03f1@enterprisedb.com>
Permalink:  ../98ddbd3e-392e-589e-40a7-643111ce03f1@enterprisedb.com/
Also on:    postgresql.org/message-id/98ddbd3e-392e-589e-40a7-643111ce03f1@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, vik@postgresfriends.org
  Subject: Re: Clean up optional rules in grammar
  In-Reply-To: <98ddbd3e-392e-589e-40a7-643111ce03f1@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox