From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: errbacktrace
Date: Tue, 13 Aug 2019 10:14:51 -0400
Message-ID: <992.1565705691@sss.pgh.pa.us> (raw)
In-Reply-To: <35beac83-bf15-9d79-05c4-2dccd0834993@2ndquadrant.com>
References: <20190708162851.GA11054@alvherre.pgsql>
<de6cb49b-1969-66f5-ac71-fbff5fd3be25@2ndquadrant.com>
<3814a094-7dcd-106b-d2ad-7ef78f563356@2ndquadrant.com>
<35beac83-bf15-9d79-05c4-2dccd0834993@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> I have changed the configuration setting to backtrace_functions plural,
> so that you can debug more than one location at once. I had originally
> wanted to do that but using existing functions like
> SplitIdentifierString() resulted in lots of complications with error
> handling (inside error handling!). So here I just hand-coded the list
> splitting. Seems simple enough.
I think it's a pretty bad idea for anything invocable from elog to
trample on the process-wide strtok() state. Even if there's no
conflict today, there will be one eventually, unless you are going
to adopt the position that nobody else is allowed to use strtok().
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, alvherre@2ndquadrant.com, 9erthalion6@gmail.com, thomas.munro@gmail.com
Subject: Re: errbacktrace
In-Reply-To: <992.1565705691@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox