From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Shinya Okano <btokanosn@oss.nttdata.com>
To: Kasahara Tatsuhito <kasahara.tatsuhito@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add a description to the documentation that toast_tuple_target affects "Main"
Date: Thu, 15 Oct 2020 11:12:10 +0900
Message-ID: <992966ae-7e8c-9adb-054a-243d74ac487a@oss.nttdata.com> (raw)
In-Reply-To: <cfe3c1f5f0987c70ddde187d411739e3@oss.nttdata.com>
References: <93f46e311a67422e89e770d236059817@oss.nttdata.com>
<CAP0=ZVJ9Wh2RnphL4nB6PuhODCxeMBBkzg3=5oSu+1FMOaNK6Q@mail.gmail.com>
<a4941ace-b898-3bd4-270f-2ccc1dc2af07@oss.nttdata.com>
<cfe3c1f5f0987c70ddde187d411739e3@oss.nttdata.com>
On 2020/10/14 16:21, Shinya Okano wrote:
> On 2020-10-14 01:30, Fujii Masao wrote:
>> On 2020/10/13 10:40, Kasahara Tatsuhito wrote:
>>> On Fri, Oct 9, 2020 at 5:44 PM Shinya Okano <btokanosn@oss.nttdata.com> wrote:
>>>> Regarding the toast_tuple_target parameter of CREATE TABLE, the
>>>> documentation says that it only affects External or Extended, but it
>>>> actually affects the compression of Main as well.
>>>>
>>>> The attached patch modifies the document to match the actual behavior.
>>> +1
>>
>> +1
>>
>> + we try to compress long column values or to move into TOAST tables, and
>>
>> "we try to compress and/or move long column values into TOAST tables,
>> and" is better?
>
> Thank you everyone for reviews.
> I attached the new version of the patch.
Thanks for updating the patch! Pushed.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, btokanosn@oss.nttdata.com, kasahara.tatsuhito@gmail.com
Subject: Re: Add a description to the documentation that toast_tuple_target affects "Main"
In-Reply-To: <992966ae-7e8c-9adb-054a-243d74ac487a@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox