From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: btnakamichin <btnakamichin@oss.nttdata.com>
To: pgsql-hackers@postgresql.org
Subject: Re: Feature improvement of tab completion for DEALLOCATE
Date: Fri, 25 Sep 2020 14:30:37 +0900
Message-ID: <997a84af-c2e2-abe4-aca2-abdfb7383346@oss.nttdata.com> (raw)
In-Reply-To: <ec1a45b06edfce13706f2c765778d8c2@oss.nttdata.com>
References: <ec1a45b06edfce13706f2c765778d8c2@oss.nttdata.com>
On 2020/09/25 13:45, btnakamichin wrote:
> Hello!
>
> I’d like to improve the deallocate tab completion.
>
> The deallocate tab completion can’t complement “ALL”. Therefore, this patch fixes the problem.
Thanks for the patch! It looks basically good, but I think it's better
to add newline just before UNION to avoid long line, as follows.
- COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
+ COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
+ " UNION SELECT 'ALL'");
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, btnakamichin@oss.nttdata.com
Subject: Re: Feature improvement of tab completion for DEALLOCATE
In-Reply-To: <997a84af-c2e2-abe4-aca2-abdfb7383346@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox