From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: btnakamichin <btnakamichin@oss.nttdata.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Feature improvement of tab completion for DEALLOCATE
Date: Mon, 28 Sep 2020 11:31:42 +0900
Message-ID: <d12635e7-69b9-15fd-3b6d-014645ffb851@oss.nttdata.com> (raw)
In-Reply-To: <680a8129485eb754f31ad0ccc1f7151f@oss.nttdata.com>
References: <ec1a45b06edfce13706f2c765778d8c2@oss.nttdata.com>
<997a84af-c2e2-abe4-aca2-abdfb7383346@oss.nttdata.com>
<680a8129485eb754f31ad0ccc1f7151f@oss.nttdata.com>
On 2020/09/25 15:18, btnakamichin wrote:
> 2020-09-25 14:30 に Fujii Masao さんは書きました:
>> On 2020/09/25 13:45, btnakamichin wrote:
>>> Hello!
>>>
>>> I’d like to improve the deallocate tab completion.
>>>
>>> The deallocate tab completion can’t complement “ALL”. Therefore, this patch fixes the problem.
>>
>> Thanks for the patch! It looks basically good, but I think it's better
>> to add newline just before UNION to avoid long line, as follows.
>>
>> - COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements);
>> + COMPLETE_WITH_QUERY(Query_for_list_of_prepared_statements
>> + " UNION SELECT 'ALL'");
>>
>> Regards,
>
> Thank you, I appreciate your comment.
>
> I have attached pattch with newline.
Thanks for updating the patch! But it contains only the diff from the previous patch.
Anyway, I pushed the change that you proposed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, btnakamichin@oss.nttdata.com
Subject: Re: Feature improvement of tab completion for DEALLOCATE
In-Reply-To: <d12635e7-69b9-15fd-3b6d-014645ffb851@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox