public inbox for [email protected]  

help / color / mirror / Atom feed

From: Zhang Mingli <[email protected]>
To: Richard Guo <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix outdated code comments in nodeAgg.c
Date: Tue, 18 Feb 2025 20:11:22 +0800
Message-ID: <9b43912c-fbcd-430b-b4ea-b15df3401270@Spark> (raw)
In-Reply-To: <CAMbWs4-u0a9XkP7xNiEuQJLBjyOb7OQf5OScyhPC0TXbDc+JXw@mail.gmail.com>
References: <56f5ab23-e92b-4380-929d-d2aa68ccc2ca@Spark>
	<198a8d1e-0792-4e7f-828e-902aa342f36e@Spark>
	<CAMbWs4-u0a9XkP7xNiEuQJLBjyOb7OQf5OScyhPC0TXbDc+JXw@mail.gmail.com>

On Feb 10, 2025 at 16:45 +0800, Richard Guo <[email protected]>, wrote:
> On Sun, Feb 9, 2025 at 11:15 PM Zhang Mingli <[email protected]> wrote:
> > By reading the codes in nodeAgg.c, I found that some comments are outdated.
> > The comments referred to the function lookup_hash_entry(), which has been removed in commit b563594.
> > I've adjusted the comments to refer to the correct function to make it clear.
>
> LGTM. This seems to be an oversight from 200f6100a, in which the
> function lookup_hash_entry() was removed.
>
> Thanks
> Richard
Hi,

Thanks for review, added it to commitfest https://commitfest.postgresql.org/patch/5580/


--
Zhang Mingli
HashData

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Fix outdated code comments in nodeAgg.c
  In-Reply-To: <9b43912c-fbcd-430b-b4ea-b15df3401270@Spark>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox