public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Nazir Bilal Yavuz <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: meson: Non-feature feature options
Date: Thu, 9 Mar 2023 14:45:24 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAN55FZ1=-jb38PujfcMWjAH8vDTYoxrgvz_oha_p+q0quMtzCw@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAN55FZ2Bz5P_sd2+1KBwWa9v4vDByM2UX7rKfzQs7yj6buojsg@mail.gmail.com>
	<[email protected]>
	<CAN55FZ3JkWJRgBOvaB0VDYg1F+v3QMg4vwVae1gpQ+mnsYc-3g@mail.gmail.com>
	<[email protected]>
	<CAN55FZ1UFQfKifUV=oAf+WseCxD0Kq3g_AvWEEety9VneMvzvw@mail.gmail.com>
	<[email protected]>
	<CAN55FZ1=-jb38PujfcMWjAH8vDTYoxrgvz_oha_p+q0quMtzCw@mail.gmail.com>

On 03.03.23 11:01, Nazir Bilal Yavuz wrote:
> On Fri, 3 Mar 2023 at 12:16, Peter Eisentraut
> <[email protected]> wrote:
>>
>> On 02.03.23 11:41, Nazir Bilal Yavuz wrote:
>>> I am kind of confused. I added these checks for considering other SSL
>>> implementations in the future, for this reason I have two nested if
>>> checks. The top one is for checking if we need to search an SSL
>>> library and the nested one is for checking if we need to search this
>>> specific SSL library. What do you think?
>>
>> I suppose that depends on how you envision integrating other SSL
>> libraries into this logic.  It's not that important right now; if the
>> structure makes sense to you, that's fine.
>>
>> Please send an updated patch with the small changes that have been
>> mentioned.
>>
> 
> The updated patch is attached.

This seems to work well.

One flaw, the "External libraries" summary shows something like

  ssl                    : YES 3.0.7

It would be nice if it showed "openssl".

How about we just hardcode "openssl" here instead?  We could build that 
array dynamically, of course, but maybe we leave that until we actually 
have a need?

view thread (22+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: meson: Non-feature feature options
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox