public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: Magnus Hagander <[email protected]>
Cc: Tim McNamara <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: New developer papercut - Makefile references INSTALL
Date: Wed, 19 Jan 2022 14:54:14 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<CABUevEw4qN0jQyWyo7w4YkJRV=F15VSE_tLTL-UcPkYAAFEZVg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>

> On 18 Jan 2022, at 17:05, Peter Eisentraut <[email protected]> wrote:
> On 18.01.22 16:51, Daniel Gustafsson wrote:

>> I plan on applying the attached which address the feedback given.
> 
> The indentation of the two INSTRUCTIONS= lines uses a different mix of tabs and spaces, so it looks a bit weird depending on how you view it.
> 
> It's also a bit strange that the single quotes are part of the value of $INSTRUCTIONS rather than part of the fixed text.

Fixed both of these, thanks!

> The URL links to the "devel" version of the installation instructions, which will not remain appropriate after release.  I don't know how to fix that without creating an additional maintenance point.  Since README.git already contains that link, I would leave off the web site business and just make the change of the dynamically chosen file name.

I ended up pushing this with the URL in place as there IMO was consensus in the
thread for including it.  We could if we want to update it to point to v15 docs
once we branch off, but anything more than that is probably in the diminishing
returns territory in terms of effort involved.

--
Daniel Gustafsson		https://vmware.com/

view thread (7+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: New developer papercut - Makefile references INSTALL
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox