public inbox for [email protected]  

help / color / mirror / Atom feed

From: Mark Dilger <[email protected]>
To: Tom Lane <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Cc: Joshua Brindle <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Jeff Davis <[email protected]>
Cc: Joe Conway <[email protected]>
Subject: Re: New Object Access Type hooks
Date: Mon, 4 Apr 2022 13:28:17 -0700
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CA+hUKG+LOza8iSLiv6ymn=0R8S0x-R7KaqZmYfY+_b_cubcDOg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>



> On Apr 4, 2022, at 12:05 PM, Tom Lane <[email protected]> wrote:
> 
> I wrote:
>> The "terminating connection" warning absolutely should get through,
> 
> ... oh, no, that's not guaranteed at all, since it's sent from quickdie().
> So scratch that.  Maybe we'd better add "could not send data to server"
> to the regex?

If it fails in pqsecure_raw_write(), you get either "server closed the connection unexpectedly" or "could not send data to server".  Do we need to support pgtls_write() or pg_GSS_write(), which have different error messages?  Can anybody run the tests with TLS or GSS enabled?  I assume the test framework prevents this, but I didn't check too closely....

Is it possible that pgFlush will call pqSendSome which calls pqReadData before trying to write anything, and get back a "could not receive data from server" from pqsecure_raw_read()?

It's a bit hard to prove to myself which paths might be followed through this code.  Thoughts?

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: New Object Access Type hooks
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox