public inbox for [email protected]
help / color / mirror / Atom feedFrom: Amit Kapila <[email protected]>
To: Bertrand Drouvot <[email protected]>
Cc: Michael Paquier <[email protected]>
Cc: Hayato Kuroda (Fujitsu) <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: Fix 035_standby_logical_decoding.pl race conditions
Date: Wed, 9 Apr 2025 12:07:31 +0530
Message-ID: <CAA4eK1+Eg-KwLX-UDY-1d0pFj45LiSaGrdrrDYv56YW+fStPLw@mail.gmail.com> (raw)
In-Reply-To: <Z/YLrTO8/[email protected]>
References: <OSCPR01MB14966608F78B5BFC907CF8E82F5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAA4eK1Kd7Cxc=GBz58O_EX5xrQ5TzyNsHmqEtQNR9j=ox74u1w@mail.gmail.com>
<OSCPR01MB149666E4ECE1C38C60E496EDCF5AE2@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<CAA4eK1KBiW+wBFiNgPjm5VyKXCKUQ8igkmf4rnS98=P3RnAukg@mail.gmail.com>
<OSCPR01MB14966BE900F2F29594D5E1FE7F5B52@OSCPR01MB14966.jpnprd01.prod.outlook.com>
<[email protected]>
<Z/S/1sE64bbM4/[email protected]>
<[email protected]>
<Z/[email protected]>
<[email protected]>
<Z/YLrTO8/[email protected]>
On Wed, Apr 9, 2025 at 11:24 AM Bertrand Drouvot
<[email protected]> wrote:
>
> On Wed, Apr 09, 2025 at 12:03:06PM +0900, Michael Paquier wrote:
> > On Tue, Apr 08, 2025 at 06:42:53AM +0000, Bertrand Drouvot wrote:
> > > Fully agree. Will need to find another way to prevent a process to wait between the
> > > wakeup and the detach. I'll open a dedicated thread.
> >
> > By the way, there is a small thing that's itching me a bit about the
> > change done in LogStandbySnapshot() for 105b2cb33617. Could it be
> > useful for debugging to add a elog(DEBUG1) with the LSN returned by
> > GetInsertRecPtr() when taking the short path? We don't have any
> > visibility when the shortcut path is taken, which seems annoying in
> > the long term if we use the injection point skip-log-running-xacts for
> > other tests, and I suspect that there will be some as the standby
> > snapshots can be really annoying in tests where we want a predictible
> > set of WAL records when wal_level is "replica" or "logical".
>
> Yeah, I also think that would be good to have some way to debug this.
>
I can't think of a good reason to have this DEBUG1 as there is no
predictability of it getting generated even with tests using an
injection point. OTOH, I don't have any objections to it if you would
like to proceed with this.
--
With Regards,
Amit Kapila.
view thread (3+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fix 035_standby_logical_decoding.pl race conditions
In-Reply-To: <CAA4eK1+Eg-KwLX-UDY-1d0pFj45LiSaGrdrrDYv56YW+fStPLw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox