public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amit Kapila <[email protected]>
To: Peter Smith <[email protected]>
Cc: Alvaro Herrera <[email protected]>
Cc: Zhijie Hou (Fujitsu) <[email protected]>
Cc: Thomas Munro <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: subscription/015_stream sometimes breaks
Date: Tue, 29 Aug 2023 09:48:11 +0530
Message-ID: <CAA4eK1+yLPNN5jj2ezONZ5rZ7bc2JYNtYCfwWh3A4Y0g3vghmw@mail.gmail.com> (raw)
In-Reply-To: <CAHut+PuwaF4Sb41pWQk69d2WO_ZJQpj-_2JkQvP=1jwozUpcCQ@mail.gmail.com>
References: <CAA4eK1KEYtgC3mB683iEq-CQUUSA8=3ZRYB9ZMbWHaU8hey2uA@mail.gmail.com>
	<[email protected]>
	<CAA4eK1JQEaHra+of4eQFyBFzONLhXNscT0miCVHeqgQp7+00AQ@mail.gmail.com>
	<CAA4eK1Jg32htSrjKCAcrvFu+bztUNhdWem8RubuTwgABKjXGDg@mail.gmail.com>
	<CAHut+PuwaF4Sb41pWQk69d2WO_ZJQpj-_2JkQvP=1jwozUpcCQ@mail.gmail.com>

On Mon, Aug 28, 2023 at 5:35 AM Peter Smith <[email protected]> wrote:
>
> On Fri, Aug 25, 2023 at 8:15 PM Amit Kapila <[email protected]> wrote:
>
> IMO there are inconsistencies in the second patch that was pushed.
>
> 1. In the am_xxx functions, why is there Assert 'in_use' only for the
> APPLY / PARALLEL_APPLY workers but not for TABLESYNC workers?
>
> 2. In the am_xxx functions there is now Assert 'in_use', so why are we
> still using macros to check again what we already asserted is not
> possible? (Or, if the checking overkill was a deliberate choice then
> why is there no isLeaderApplyWorker macro?)
>
> ~
>
> PSA a small patch to address these.
>

I find your suggestions reasonable. Alvaro, do you have any comments?

-- 
With Regards,
Amit Kapila.

view thread (4+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: subscription/015_stream sometimes breaks
  In-Reply-To: <CAA4eK1+yLPNN5jj2ezONZ5rZ7bc2JYNtYCfwWh3A4Y0g3vghmw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox