public inbox for [email protected]  

help / color / mirror / Atom feed

From: Sami Imseih <[email protected]>
To: Nathan Bossart <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Rename LWLockNewTrancheId() parameter from "name" to "tranche_name"
Date: Thu, 26 Mar 2026 14:33:52 -0500
Message-ID: <CAA5RZ0uJ15COoA5xxvVcMH_WKqozc=ozH_JYuyO6PJjvLyCJ0g@mail.gmail.com> (raw)
In-Reply-To: <acWJXUQVYExHC063@nathan>
References: <CAA5RZ0tpJ8GBrWshkUJ29Fu3juqgdbr=kfK3O9FMLrEy1zPOkg@mail.gmail.com>
	<acWJXUQVYExHC063@nathan>

> > While looking at something nearby, I noticed a naming inconsistency for
> > the parameter name in LWLockNewTrancheId(). It should be tranche_name,
> > similar to RequestNamedLWLockTranche(), and in other places it's
> > referenced in the docs/comments.
>
> I don't mind changing it, but I don't find "tranche_name" to be
> substantially better than "name" in this case.

It's just a matter of consistency and it's more descriptive to the
caller, IMO.

--
Sami Imseih
Amazon Web Services (AWS)

view thread (3+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Rename LWLockNewTrancheId() parameter from "name" to "tranche_name"
  In-Reply-To: <CAA5RZ0uJ15COoA5xxvVcMH_WKqozc=ozH_JYuyO6PJjvLyCJ0g@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox