public inbox for [email protected]  

help / color / mirror / Atom feed

From: Nathan Bossart <[email protected]>
To: Sami Imseih <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: Rename LWLockNewTrancheId() parameter from "name" to "tranche_name"
Date: Thu, 26 Mar 2026 14:30:37 -0500
Message-ID: <acWJXUQVYExHC063@nathan> (raw)
In-Reply-To: <CAA5RZ0tpJ8GBrWshkUJ29Fu3juqgdbr=kfK3O9FMLrEy1zPOkg@mail.gmail.com>
References: <CAA5RZ0tpJ8GBrWshkUJ29Fu3juqgdbr=kfK3O9FMLrEy1zPOkg@mail.gmail.com>

On Thu, Mar 26, 2026 at 01:34:38PM -0500, Sami Imseih wrote:
> While looking at something nearby, I noticed a naming inconsistency for
> the parameter name in LWLockNewTrancheId(). It should be tranche_name,
> similar to RequestNamedLWLockTranche(), and in other places it's
> referenced in the docs/comments.

I don't mind changing it, but I don't find "tranche_name" to be
substantially better than "name" in this case.  Maybe it's a little
clearer, but there's not much room for confusion here.

-- 
nathan

view thread (3+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Rename LWLockNewTrancheId() parameter from "name" to "tranche_name"
  In-Reply-To: <acWJXUQVYExHC063@nathan>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox