public inbox for [email protected]  

help / color / mirror / Atom feed

From: Amul Sul <[email protected]>
To: vignesh C <[email protected]>
Cc: Fujii Masao <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
Date: Thu, 16 Apr 2026 18:00:38 +0530
Message-ID: <CAAJ_b975xBx_No+i69F5EAcRgDaT-G0h=XPFrqL1n_zBSwKSRQ@mail.gmail.com> (raw)
In-Reply-To: <CALDaNm0MO0qSwN2tbEyzogocdV4COwGQs9_OD7r+P4GaWnac=g@mail.gmail.com>
References: <CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com>
	<CAHGQGwEuEd2StEYuP9vj+jCFT=hQbX8xcQeq8=Kj8r9xT3vmyg@mail.gmail.com>
	<CALDaNm0zJuUon52OEx5SpMoP8LEGJh+=PyYqwmcD7Zh97_dnJg@mail.gmail.com>
	<CAHGQGwGFP1AEQ1+=95LrVpUUOOPeebi13aEXXebSZ7bvWVT=wA@mail.gmail.com>
	<CALDaNm0MO0qSwN2tbEyzogocdV4COwGQs9_OD7r+P4GaWnac=g@mail.gmail.com>

On Thu, Apr 16, 2026 at 4:25 PM vignesh C <[email protected]> wrote:
>
> On Thu, 16 Apr 2026 at 09:42, Fujii Masao <[email protected]> wrote:
> >
> > On Mon, Apr 13, 2026 at 4:10 PM vignesh C <[email protected]> wrote:
> > > I felt these also should be updated, the attached v2 version patch
> > > includes the changes for the same.
> >
> > Thanks for updating the patch!
> >
> > -       applyPtr = (latestApplyPtr == InvalidXLogRecPtr) ?
> > +       applyPtr = (XLogRecPtrIsInvalid(latestApplyPtr)) ?
> >
> > XLogRecPtrIsValid() should be used here, instead?

The outer parentheses do not seem to be needed, as
XLogRecPtrIsInvalid() already includes them.

Other than that, the v3 patch looks good to me.

Regards,
Amul

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
  In-Reply-To: <CAAJ_b975xBx_No+i69F5EAcRgDaT-G0h=XPFrqL1n_zBSwKSRQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox