public inbox for [email protected]  

help / color / mirror / Atom feed
From: vignesh C <[email protected]>
To: Fujii Masao <[email protected]>
Cc: Amul Sul <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
Date: Thu, 16 Apr 2026 19:42:07 +0530
Message-ID: <CALDaNm03644=iewXg85BU5Kg+RWyk97BYOappjR6ojn25f4Mcg@mail.gmail.com> (raw)
In-Reply-To: <CAHGQGwEbDkqcDU=zHeQFC-dyBDv7UM108bFCqd7gkx3b=UROig@mail.gmail.com>
References: <CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com>
	<CAHGQGwEuEd2StEYuP9vj+jCFT=hQbX8xcQeq8=Kj8r9xT3vmyg@mail.gmail.com>
	<CALDaNm0zJuUon52OEx5SpMoP8LEGJh+=PyYqwmcD7Zh97_dnJg@mail.gmail.com>
	<CAHGQGwGFP1AEQ1+=95LrVpUUOOPeebi13aEXXebSZ7bvWVT=wA@mail.gmail.com>
	<CALDaNm0MO0qSwN2tbEyzogocdV4COwGQs9_OD7r+P4GaWnac=g@mail.gmail.com>
	<CAAJ_b975xBx_No+i69F5EAcRgDaT-G0h=XPFrqL1n_zBSwKSRQ@mail.gmail.com>
	<CAHGQGwEbDkqcDU=zHeQFC-dyBDv7UM108bFCqd7gkx3b=UROig@mail.gmail.com>

On Thu, 16 Apr 2026 at 19:36, Fujii Masao <[email protected]> wrote:
>
> On Thu, Apr 16, 2026 at 9:31 PM Amul Sul <[email protected]> wrote:
> > The outer parentheses do not seem to be needed, as
> > XLogRecPtrIsInvalid() already includes them.
> >
> > Other than that, the v3 patch looks good to me.
>
> I've updated the patch based on Amul's suggestion and pushed it. Thanks!

Thanks for pushing the patch.

Regards,
Vignesh





view thread (9+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
  In-Reply-To: <CALDaNm03644=iewXg85BU5Kg+RWyk97BYOappjR6ojn25f4Mcg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox