public inbox for [email protected]
help / color / mirror / Atom feedFrom: jian he <[email protected]>
To: Chao Li <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Zsolt Parragi <[email protected]>
Cc: [email protected]
Subject: Re: Fix bug of CHECK constraint enforceability recursion
Date: Wed, 17 Jun 2026 11:27:31 +0800
Message-ID: <CACJufxEXyn_0RGBmULM4QQykSCh9wxXF-6wNnHo1pNefacPSag@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
On Tue, Jun 9, 2026 at 8:32 AM Chao Li <[email protected]> wrote:
>
> In v10, I split the “because” part to a errdetail, also moved out NOT ENFORCED out of the translate message.
>
ATCheckCheckConstrHasEnforcedParent
``````
if (constraints_equivalent(parenttup, contuple,
RelationGetDescr(conrel)))
{
``````
The above IF condition is basically always true (see
MergeConstraintsIntoExisting), unless an inherited check constraint
has a
different definition, which should not happen.
So I did a quick refactor here, which also drops the nesting level down by one.
Other than that, v10 looks good to me.
--
jian
https://www.enterprisedb.com/
Attachments:
[application/octet-stream] v10-0001-misc-refactor-ATCheckCheckConstrHasEnforcedParent.nocfbot (3.1K, 2-v10-0001-misc-refactor-ATCheckCheckConstrHasEnforcedParent.nocfbot)
download
view thread (32+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Fix bug of CHECK constraint enforceability recursion
In-Reply-To: <CACJufxEXyn_0RGBmULM4QQykSCh9wxXF-6wNnHo1pNefacPSag@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox