public inbox for [email protected]  

help / color / mirror / Atom feed

From: wenhui qiu <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: [PATCH] Little refactoring of portalcmds.c
Date: Mon, 27 Oct 2025 17:50:21 +0800
Message-ID: <CAGjGUAJJCO0cYA297226epqwfj+UutGnYUigng9riApJo+pm=Q@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAJ7c6TOQq=R5MmrbkrGYdqTQEaaoEgMq-ZraXPjkdCJ60oJcaQ@mail.gmail.com>
	<[email protected]>

Hi Aleksander Alekseev
> The proposed patch places some repetitive code in a helper function.
> The value of this change is arguably not that high but it makes the
> code a bit neater IMO.
I  agree with your suggestion to refactor the duplicated code into a
function.

Thanks

On Mon, Oct 27, 2025 at 2:03 PM Quan Zongliang <[email protected]>
wrote:

>
>
> On 10/8/25 10:02 PM, Aleksander Alekseev wrote:
> > Hi,
> >
> > The proposed patch places some repetitive code in a helper function.
> > The value of this change is arguably not that high but it makes the
> > code a bit neater IMO.
> >
>
> It also reduces the ease of reading the code.
> Just add a function for a single if statement. I don't think it's
> necessary.
>
> Regards,
> Quan Zongliang
>
>
>
>

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Little refactoring of portalcmds.c
  In-Reply-To: <CAGjGUAJJCO0cYA297226epqwfj+UutGnYUigng9riApJo+pm=Q@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox