public inbox for [email protected]  

help / color / mirror / Atom feed
From: Fujii Masao <[email protected]>
To: Chao Li <[email protected]>
Cc: wang.xiao.peng <[email protected]>
Cc: [email protected]
Cc: PostgreSQL Hackers <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Hannu Krosing <[email protected]>
Subject: Re: pg_test_timing: fix unit typo and widen diff type
Date: Thu, 23 Apr 2026 01:11:53 +0900
Message-ID: <CAHGQGwHFHghHRn1427m_ZH_D9t0gytKRa96Uid-pJ4VyZCvyOw@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAP53PkwEZ+UMmwA8cbUSUdE6phXi+xWmn5t-YAnvKf0qoBnOvg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAHGQGwEM=s5vXPpXoismwRMNCnAmwwMJPnQEQYbPFTJGouV0rQ@mail.gmail.com>
	<[email protected]>

On Wed, Apr 22, 2026 at 5:58 PM Chao Li <[email protected]> wrote:
> PFA v4:
>
> * 0001 unchanged from v3.
> * 0002 changed size of histogram[] 64.

Thanks for updating the patch!

Since patch 0001 is a bug fix, it should be backpatched to the supported stable
branches. However, in v19 the unit should be changed like s/ms/ns, while in v18
and earlier s/ms/us, since those older branches report the diff in microseconds.
Right?

Patch 0002 looks more like an improvement than a bug fix, so we should probably
wait for the next CommitFest before committing it. Thoughts?

Regards,


-- 
Fujii Masao





view thread (11+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: pg_test_timing: fix unit typo and widen diff type
  In-Reply-To: <CAHGQGwHFHghHRn1427m_ZH_D9t0gytKRa96Uid-pJ4VyZCvyOw@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox