public inbox for [email protected]  

help / color / mirror / Atom feed

From: Fujii Masao <[email protected]>
To: Steven Niu <[email protected]>
Cc: Álvaro Herrera <[email protected]>
Cc: Shinya Kato <[email protected]>
Cc: Chao Li <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: file_fdw: Support multi-line HEADER option.
Date: Thu, 22 Jan 2026 10:18:08 +0900
Message-ID: <CAHGQGwHUyyZMWEY+T6-3kRLE1uwJhUeeKOFpfM_AW4RipxNQNg@mail.gmail.com> (raw)
In-Reply-To: <MN2PR15MB3021F257D141B286206F0DC6A796A@MN2PR15MB3021.namprd15.prod.outlook.com>
References: <CAHGQGwGWyApGA0L-uE819xeinwSonPXQfV1diBUCkR+AcgxuOw@mail.gmail.com>
	<[email protected]>
	<CAHGQGwH3PJ8an=Z-70s3Nv=YY3btAJ=qD76Tivh2XgnABq8Xmg@mail.gmail.com>
	<MN2PR15MB3021F257D141B286206F0DC6A796A@MN2PR15MB3021.namprd15.prod.outlook.com>

On Wed, Jan 21, 2026 at 5:18 PM Steven Niu <[email protected]> wrote:
> I've noticed an inconsistent naming convention in the patch:
> we use a capitalized Boolean for the boolean type, but a lowercase integer when referring to the value type.
>
> + errmsg("%s requires a Boolean value, an integer "
> +               "value greater than or equal to zero
>
> Is there any reason why we follow this mixed style?

I don't have a strong opinion on this. "Boolean value" has been used in command
error messages from before, and I couldn't find any messages that use the term
"Integer". So I committed the patch with the original wording. If this turns out
to be an issue, we can revisit it later.


> Another nitpick in v6-0001 patch:
> tow whitespaces are between "special" and "value"
> +                second %s is the special  value "match" for that option */

Thanks for catching that! I've fixed it.

I've pushed the patches. Thanks!

Regards,

-- 
Fujii Masao

view thread (5+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: file_fdw: Support multi-line HEADER option.
  In-Reply-To: <CAHGQGwHUyyZMWEY+T6-3kRLE1uwJhUeeKOFpfM_AW4RipxNQNg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox