public inbox for [email protected]  

help / color / mirror / Atom feed

From: Ayush Tiwari <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Ashutosh Bapat <[email protected]>
Subject: Re: [PATCH] Clean up property graph error messages
Date: Thu, 7 May 2026 14:34:05 +0530
Message-ID: <CAJTYsWWGfGmdbKAet5jj326ik6zbKivtn9KBfFxB9uLNLuk6yA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CAJTYsWXFy1j_T82+M_S9kFxU414tQYnZQD-b82=oL_LbG_5fPQ@mail.gmail.com>
	<[email protected]>

Hi,


On Thu, 7 May 2026 at 14:15, Peter Eisentraut <[email protected]> wrote:

>
> > and moves a
> > ReleaseSysCache() call before an ERROR ereport in
> > check_element_properties().
> >
> > The existing code should be cleaned up by
> > the resource owner on the ERROR path, but the explicit ReleaseSysCache()
> > placed after ereport(ERROR) was unreachable.
>
> I think that's fine.  I don't think the change makes this better.
>

IIUC that is dead code right now, it never reaches that point to release?

Regards,
Ayush

view thread (9+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] Clean up property graph error messages
  In-Reply-To: <CAJTYsWWGfGmdbKAet5jj326ik6zbKivtn9KBfFxB9uLNLuk6yA@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox