public inbox for [email protected]  

help / color / mirror / Atom feed

From: shveta malik <[email protected]>
To: Amit Kapila <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: shveta malik <[email protected]>
Subject: Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
Date: Tue, 3 Sep 2024 11:42:32 +0530
Message-ID: <CAJpy0uANPf_XYdDKeWYcweJyemdsGJ0Z+mjJba_0W9mCuEpEkg@mail.gmail.com> (raw)
In-Reply-To: <CAA4eK1K0aGmwQarFB=exVd576DLdCyALaKY70oAFn77B1j5a3A@mail.gmail.com>
References: <CAHut+PuvsyA5v8y7rYoY9mkDQzUhwaESM05yCByTMaDoRh30tA@mail.gmail.com>
	<CAJpy0uC6bDq9FhjGP8DnvRgoem1n3Z3ketZKKBg8zi=BMng1DQ@mail.gmail.com>
	<CAA4eK1K0aGmwQarFB=exVd576DLdCyALaKY70oAFn77B1j5a3A@mail.gmail.com>

On Tue, Sep 3, 2024 at 10:43 AM Amit Kapila <[email protected]> wrote:
>
> > >
> > > To summarize, the current description wrongly describes the field as a
> > > time duration:
> > > "The time since the slot has become inactive."
> > >
> > > I suggest replacing it with:
> > > "The slot has been inactive since this time."
> > >
> >
> > +1 for the change. If I had read the document without knowing about
> > the patch, I too would have interpreted it as a duration.
> >
>
> The suggested change looks good to me as well. I'll wait for a day or
> two before pushing to see if anyone thinks otherwise.

Shall we make the change in code-comment as well:

typedef struct ReplicationSlot
{
...
        /* The time since the slot has become inactive */
        TimestampTz inactive_since;
}

thanks
Shveta

view thread (5+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: DOCS - pg_replication_slot . Fix the 'inactive_since' description
  In-Reply-To: <CAJpy0uANPf_XYdDKeWYcweJyemdsGJ0Z+mjJba_0W9mCuEpEkg@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox