public inbox for [email protected]
help / color / mirror / Atom feedFrom: Mahendra Singh Thalor <[email protected]>
To: PostgreSQL-development <[email protected]>
Subject: pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl
Date: Sun, 15 Mar 2026 22:59:53 +0530
Message-ID: <CAKYtNArGv45WX3mpOrQ9p6+gb7FvA8qF14FB5pZfcDJ9PQrWKA@mail.gmail.com> (raw)
Hi,
While doing some changes, I found a typo error(wrong word) in 001_basic.pl
file.
In 31a8b77a9244a0883e1968adc, we added some test cases for pg_dump,
pg_restore and pg_dumpall.
In one error case, we added 'pg_dump' name instead of 'pg_rsetore'.
diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl
index 9f12ca6c51d..ff1d422292e 100644
--- a/src/bin/pg_dump/t/001_basic.pl
+++ b/src/bin/pg_dump/t/001_basic.pl
@@ -144,7 +144,7 @@ command_fails_like(
command_fails_like(
[ 'pg_restore', '-f -', '-F', 'garbage' ],
qr/\Qpg_restore: error: unrecognized archive format "garbage";\E/,
- 'pg_dump: unrecognized archive format');
+ 'pg_restore: unrecognized archive format');
Here, I am attaching a patch to fix this.This patch can be applied till
PG14.
I think we should back-patch till PG14. Please review this.
--
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com
Attachments:
[text/x-patch] v01-pg_restore-TAP-test-wrong-word-in-hint.patch (1.1K, 3-v01-pg_restore-TAP-test-wrong-word-in-hint.patch)
download | inline diff:
From e2ac7e08da8be18dbe131242a0b8c13e999b0d43 Mon Sep 17 00:00:00 2001
From: Mahendra Singh Thalor <[email protected]>
Date: Sun, 15 Mar 2026 22:55:59 +0530
Subject: [PATCH] pg_restore TAP test fix wrong word
While doing some changes, I found a typo error(wrong word)
in 001_basic.pl file.
In 31a8b77a9244a0883e1968adc, we added some test cases for pg_dump,
pg_restore and pg_dumpall. In one error case, we added the 'pg_dump'
name instead of 'pg_rsetore'.
back-patch till PG14
---
src/bin/pg_dump/t/001_basic.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl
index 2f5eb48e7b8..9305c46f4af 100644
--- a/src/bin/pg_dump/t/001_basic.pl
+++ b/src/bin/pg_dump/t/001_basic.pl
@@ -199,7 +199,7 @@ command_fails_like(
command_fails_like(
[ 'pg_restore', '-f -', '-F', 'garbage' ],
qr/\Qpg_restore: error: unrecognized archive format "garbage";\E/,
- 'pg_dump: unrecognized archive format');
+ 'pg_restore: unrecognized archive format');
command_fails_like(
[ 'pg_dump', '--on-conflict-do-nothing' ],
--
2.52.0
view thread (5+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected]
Subject: Re: pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl
In-Reply-To: <CAKYtNArGv45WX3mpOrQ9p6+gb7FvA8qF14FB5pZfcDJ9PQrWKA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox