public inbox for [email protected]help / color / mirror / Atom feed
pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl 5+ messages / 3 participants [nested] [flat]
* pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl @ 2026-03-15 17:29 Mahendra Singh Thalor <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Mahendra Singh Thalor @ 2026-03-15 17:29 UTC (permalink / raw) To: pgsql-hackers Hi, While doing some changes, I found a typo error(wrong word) in 001_basic.pl file. In 31a8b77a9244a0883e1968adc, we added some test cases for pg_dump, pg_restore and pg_dumpall. In one error case, we added 'pg_dump' name instead of 'pg_rsetore'. diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl index 9f12ca6c51d..ff1d422292e 100644 --- a/src/bin/pg_dump/t/001_basic.pl +++ b/src/bin/pg_dump/t/001_basic.pl @@ -144,7 +144,7 @@ command_fails_like( command_fails_like( [ 'pg_restore', '-f -', '-F', 'garbage' ], qr/\Qpg_restore: error: unrecognized archive format "garbage";\E/, - 'pg_dump: unrecognized archive format'); + 'pg_restore: unrecognized archive format'); Here, I am attaching a patch to fix this.This patch can be applied till PG14. I think we should back-patch till PG14. Please review this. -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com Attachments: [text/x-patch] v01-pg_restore-TAP-test-wrong-word-in-hint.patch (1.1K, 3-v01-pg_restore-TAP-test-wrong-word-in-hint.patch) download | inline diff: From e2ac7e08da8be18dbe131242a0b8c13e999b0d43 Mon Sep 17 00:00:00 2001 From: Mahendra Singh Thalor <[email protected]> Date: Sun, 15 Mar 2026 22:55:59 +0530 Subject: [PATCH] pg_restore TAP test fix wrong word While doing some changes, I found a typo error(wrong word) in 001_basic.pl file. In 31a8b77a9244a0883e1968adc, we added some test cases for pg_dump, pg_restore and pg_dumpall. In one error case, we added the 'pg_dump' name instead of 'pg_rsetore'. back-patch till PG14 --- src/bin/pg_dump/t/001_basic.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/bin/pg_dump/t/001_basic.pl b/src/bin/pg_dump/t/001_basic.pl index 2f5eb48e7b8..9305c46f4af 100644 --- a/src/bin/pg_dump/t/001_basic.pl +++ b/src/bin/pg_dump/t/001_basic.pl @@ -199,7 +199,7 @@ command_fails_like( command_fails_like( [ 'pg_restore', '-f -', '-F', 'garbage' ], qr/\Qpg_restore: error: unrecognized archive format "garbage";\E/, - 'pg_dump: unrecognized archive format'); + 'pg_restore: unrecognized archive format'); command_fails_like( [ 'pg_dump', '--on-conflict-do-nothing' ], -- 2.52.0 ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl @ 2026-03-15 23:29 Michael Paquier <[email protected]> parent: Mahendra Singh Thalor <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Michael Paquier @ 2026-03-15 23:29 UTC (permalink / raw) To: Mahendra Singh Thalor <[email protected]>; +Cc: pgsql-hackers On Sun, Mar 15, 2026 at 10:59:53PM +0530, Mahendra Singh Thalor wrote: > I think we should back-patch till PG14. Please review this. Thanks, grabbed this one for later. I am not sure if it is worth bothering about the back-branches. If somebody feels otherwise, please feel free to overwrite me and I will adapt. -- Michael Attachments: [application/pgp-signature] signature.asc (833B, 2-signature.asc) download ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl @ 2026-03-19 20:03 Mahendra Singh Thalor <[email protected]> parent: Michael Paquier <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Mahendra Singh Thalor @ 2026-03-19 20:03 UTC (permalink / raw) To: Michael Paquier <[email protected]>; +Cc: pgsql-hackers Thanks Michael for the review. Please can you push this change into master? Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com On Mon, 16 Mar 2026 at 4:59 AM, Michael Paquier <[email protected]> wrote: > On Sun, Mar 15, 2026 at 10:59:53PM +0530, Mahendra Singh Thalor wrote: > > I think we should back-patch till PG14. Please review this. > > Thanks, grabbed this one for later. I am not sure if it is worth > bothering about the back-branches. If somebody feels otherwise, > please feel free to overwrite me and I will adapt. > -- > Michael > ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl @ 2026-03-19 20:07 Nathan Bossart <[email protected]> parent: Mahendra Singh Thalor <[email protected]> 0 siblings, 1 reply; 5+ messages in thread From: Nathan Bossart @ 2026-03-19 20:07 UTC (permalink / raw) To: Mahendra Singh Thalor <[email protected]>; +Cc: Michael Paquier <[email protected]>; pgsql-hackers On Fri, Mar 20, 2026 at 01:33:00AM +0530, Mahendra Singh Thalor wrote: > Please can you push this change into master? I took care of this in commit ec80215c03. -- nathan ^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl @ 2026-03-19 20:30 Mahendra Singh Thalor <[email protected]> parent: Nathan Bossart <[email protected]> 0 siblings, 0 replies; 5+ messages in thread From: Mahendra Singh Thalor @ 2026-03-19 20:30 UTC (permalink / raw) To: Nathan Bossart <[email protected]>; +Cc: Michael Paquier <[email protected]>; pgsql-hackers On Fri, 20 Mar 2026 at 01:37, Nathan Bossart <[email protected]> wrote: > > On Fri, Mar 20, 2026 at 01:33:00AM +0530, Mahendra Singh Thalor wrote: > > Please can you push this change into master? > > I took care of this in commit ec80215c03. > > -- > nathan Thanks Nathan. I only saw the commit message. Apologize. -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com ^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2026-03-19 20:30 UTC | newest] Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-03-15 17:29 pg_restore: TAP test case typo(wrong word) for an error hint in 001_basic.pl Mahendra Singh Thalor <[email protected]> 2026-03-15 23:29 ` Michael Paquier <[email protected]> 2026-03-19 20:03 ` Mahendra Singh Thalor <[email protected]> 2026-03-19 20:07 ` Nathan Bossart <[email protected]> 2026-03-19 20:30 ` Mahendra Singh Thalor <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox