public inbox for [email protected]help / color / mirror / Atom feed
Remove commented-out code in 026_overwrite_contrecord.pl 3+ messages / 3 participants [nested] [flat]
* Remove commented-out code in 026_overwrite_contrecord.pl @ 2026-04-03 13:56 Imran Zaheer <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Imran Zaheer @ 2026-04-03 13:56 UTC (permalink / raw) To: pgsql-hackers Hi There is some unused commented line of code in the tap test file ` 026_overwrite_contrecord.pl` [1]. Looks like a left over from earlier test development. Remove it for clarity. Thanks, Imran Zaheer [1]: https://github.com/postgres/postgres/blob/b7b27eb41a5cc0b45a1a9ce5c1cde5883d7bc358/src/test/recovery... Attachments: [text/x-patch] v1-0001-Remove-commented-code-in-026_overwrite_contrecord.patch (1.1K, 3-v1-0001-Remove-commented-code-in-026_overwrite_contrecord.patch) download | inline diff: From 5eedaf7fd3c69516091a53ee281056320d3f5b21 Mon Sep 17 00:00:00 2001 From: Imran Zaheer <[email protected]> Date: Fri, 3 Apr 2026 18:31:03 +0500 Subject: [PATCH v1] Remove commented code in 026_overwrite_contrecord This commented-out CREATE TABLE statement appears to be a leftover from earlier test development and is not used in the test. Remove it for clarity. --- src/test/recovery/t/026_overwrite_contrecord.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/recovery/t/026_overwrite_contrecord.pl b/src/test/recovery/t/026_overwrite_contrecord.pl index 4f501169f42..82567ca6bfc 100644 --- a/src/test/recovery/t/026_overwrite_contrecord.pl +++ b/src/test/recovery/t/026_overwrite_contrecord.pl @@ -58,7 +58,7 @@ my $initfile = $node->safe_psql('postgres', $node->safe_psql('postgres', qq{SELECT pg_logical_emit_message(true, 'test 026', repeat('xyzxz', 123456))} ); -#$node->safe_psql('postgres', qq{create table foo ()}); + my $endfile = $node->safe_psql('postgres', 'SELECT pg_walfile_name(pg_current_wal_insert_lsn())'); ok($initfile ne $endfile, "$initfile differs from $endfile"); -- 2.34.1 ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Remove commented-out code in 026_overwrite_contrecord.pl @ 2026-04-06 09:40 vignesh C <[email protected]> parent: Imran Zaheer <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: vignesh C @ 2026-04-06 09:40 UTC (permalink / raw) To: Imran Zaheer <[email protected]>; +Cc: pgsql-hackers On Fri, 3 Apr 2026 at 19:26, Imran Zaheer <[email protected]> wrote: > > Hi > > There is some unused commented line of code in the tap test file `026_overwrite_contrecord.pl` [1]. Looks like a left over from earlier test development. I agree with you, +1 to remove this. Regards, Vignesh ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Remove commented-out code in 026_overwrite_contrecord.pl @ 2026-04-08 02:17 Michael Paquier <[email protected]> parent: vignesh C <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Michael Paquier @ 2026-04-08 02:17 UTC (permalink / raw) To: vignesh C <[email protected]>; +Cc: Imran Zaheer <[email protected]>; pgsql-hackers On Mon, Apr 06, 2026 at 03:10:50PM +0530, vignesh C wrote: > I agree with you, +1 to remove this. Thanks. This is cosmetic, so I have grabbed that for later, saved it on a staging branch with a bunch of other things. -- Michael Attachments: [application/pgp-signature] signature.asc (833B, 2-signature.asc) download ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2026-04-08 02:17 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2026-04-03 13:56 Remove commented-out code in 026_overwrite_contrecord.pl Imran Zaheer <[email protected]> 2026-04-06 09:40 ` vignesh C <[email protected]> 2026-04-08 02:17 ` Michael Paquier <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox