public inbox for [email protected]  
help / color / mirror / Atom feed
From: vignesh C <[email protected]>
To: Peter Smith <[email protected]>
Cc: Amit Kapila <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+
Date: Mon, 13 Apr 2026 08:51:06 +0530
Message-ID: <CALDaNm3nucvcX_-jU-YqX2k4dTM_qY72gFbh10SnWp4gro+ifQ@mail.gmail.com> (raw)
In-Reply-To: <CAHut+PvtmM7tCut-K-EWSq0_Hg5ey=M2NreU_Fq80SpUOgmiBw@mail.gmail.com>
References: <CAHut+Pt3t_tCYwDStkj5fG4Z=YXrHvPBA7iGdh745QipC5zKeg@mail.gmail.com>
	<CAA4eK1KUP5h++hSK6eo--jx=jRJ2TTPqYYmOg=7anCm=__S_0w@mail.gmail.com>
	<CAHut+PvtmM7tCut-K-EWSq0_Hg5ey=M2NreU_Fq80SpUOgmiBw@mail.gmail.com>

On Mon, 13 Apr 2026 at 07:45, Peter Smith <[email protected]> wrote:
>
> On Fri, Apr 10, 2026 at 8:19 PM Amit Kapila <[email protected]> wrote:
> >
> > On Fri, Apr 10, 2026 at 12:43 PM Peter Smith <[email protected]> wrote:
> > >
> > > Notice that that the describe publication says:
> > > "Tables:" and "Except tables:" (Lowercase "tables")
> > >
> > > Notice that the describe table says:
> > > "Publications:" and "Except Publications:"  (Uppercase "Publications")
> > >
> > > I think they should use a consistent case:
> > > eg1. (both lowercase) Except tables; Except publications, OR
> > > eg2. (bother uppercase) Except Tables; Except Publications
> > >
> >
> > We should follow eg1. I checked few examples where we follow same
> > pattern as eg1:
> >
> > Example-1: (See: "Tables from schemas")
> >  postgres=# \dRp+ pub1
> >                                                      Publication pub1
> >  Owner | All tables | All sequences | Inserts | Updates | Deletes |
> > Truncates | Generated columns | Via root | Description
> > -------+------------+---------------+---------+---------+---------+-----------+-------------------+----------+-------------
> >  amit  | f          | f             | t       | t       | t       | t
> >        | none              | f        |
> > Tables from schemas:
> >     "sch1"
> >
> > Example-2: ((See: "No connections")
> > postgres=# create user u1 CONNECTION LIMIT 0;
> > CREATE ROLE
> > postgres=# \du u1
> >        List of roles
> >  Role name |   Attributes
> > -----------+----------------
> >  u1        | No connections
> >
>
> Hi Amit.
>
> Thanks for the advice.
>
> PSA patch v1 to change "Except Publications" to "Except publications".

The commit message could be improved:
Date: Mon, 13 Apr 2026 12:12:00 +1000
Subject: [PATCH v1] describe table except publications

---
 src/bin/psql/describe.c                   | 2 +-

Other than that, the patch looks good to me.

Regards,
Vignesh.





view thread (19+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: EXCEPT TABLE - Case inconsistency for describe \d and \dRp+
  In-Reply-To: <CALDaNm3nucvcX_-jU-YqX2k4dTM_qY72gFbh10SnWp4gro+ifQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox