public inbox for [email protected]
help / color / mirror / Atom feedFrom: Kirill Reshke <[email protected]>
To: Alexander Korotkov <[email protected]>
Cc: Matheus Alcantara <[email protected]>
Cc: Dmitry Koval <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: MERGE PARTITIONS and DEPENDS ON EXTENSION.
Date: Wed, 22 Apr 2026 16:26:43 +0500
Message-ID: <CALdSSPiDAv4NrQfR79cX7G1OYxhnRftZK1Nn_2NdT4r0gZc=mw@mail.gmail.com> (raw)
In-Reply-To: <CAPpHfdua=Epad8j4z+xH_85RYVZ+FPuK=nPKBgh7Ky+PM4umag@mail.gmail.com>
References: <CALdSSPjXtzGM7Uk4fWRwRMXcCczge5uNirPQcYCHKPAWPkp9iQ@mail.gmail.com>
<[email protected]>
<[email protected]>
<[email protected]>
<[email protected]>
<CAPpHfdvQSmRAHu1BRTVcvgons_Smt0QW+mLP4np=QxG==WyFAg@mail.gmail.com>
<[email protected]>
<CAPpHfds2NsGvpi4fK-xBDk9S=ZY8FEsG-a3z7m_cRSJhn5GKvQ@mail.gmail.com>
<[email protected]>
<CAPpHfdt66RjWZnUakTZKk6eQ=xVrscfp9HAg8xXnxjnsgHuF-g@mail.gmail.com>
<CALdSSPi9GE8jnLCA4aUP2F5_ax6W9Ccfh_ja0iY6wkX2uUyzDw@mail.gmail.com>
<CAPpHfdua=Epad8j4z+xH_85RYVZ+FPuK=nPKBgh7Ky+PM4umag@mail.gmail.com>
On Wed, 22 Apr 2026 at 16:24, Alexander Korotkov <[email protected]> wrote:
>
> On Wed, Apr 22, 2026 at 1:48 PM Kirill Reshke <[email protected]> wrote:
> > Some minor comments:
> >
> > > +-- Sanity check: the extension can't be dropped while dependencies exist.
> > >+DROP EXTENSION test_ext3;
> >
> > This exercises something that already works on HEAD (note this is DROP
> > before first MERGE partition call ). Do we really need this?
>
> I've removed this.
>
> > > +-- An index created directly on a partition has no parent in the partitioned
> > > +-- index tree; merge must ignore such indexes (they disappear with the old
> > > +-- partition).
> > > +CREATE INDEX part_extdep_3_extra_idx ON part_extdep_3(x);
> > > +ALTER TABLE part_extdep MERGE PARTITIONS (part_extdep_merged, part_extdep_3)
> > > + INTO part_extdep_merged2;
> > > +SELECT relname FROM pg_class
> > > +WHERE relname LIKE 'part_extdep_merged2%idx' ORDER BY relname;
> >
> > Looks like this test is also redundant? This does not test new DEPENDS ON logic.
>
> I've added the dependency on this index to check index disappears with
> its dependency. I think this would make this test more relevant.
>
> Kirill, Matheus, are you ok with these change?
>
> ------
> Regards,
> Alexander Korotkov
> Supabase
v7 WFM
--
Best regards,
Kirill Reshke
view thread (21+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: MERGE PARTITIONS and DEPENDS ON EXTENSION.
In-Reply-To: <CALdSSPiDAv4NrQfR79cX7G1OYxhnRftZK1Nn_2NdT4r0gZc=mw@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox