public inbox for [email protected]
help / color / mirror / Atom feedFrom: Bharath Rupireddy <[email protected]>
To: Michael Paquier <[email protected]>
Cc: vignesh C <[email protected]>
Cc: Andrew Dunstan <[email protected]>
Cc: Dagfinn Ilmari Mannsåker <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Implement generalized sub routine find_in_log for tap test
Date: Sun, 11 Jun 2023 07:17:55 +0530
Message-ID: <CALj2ACWJ8OOQ97=EDjy-i9Jdno5ioHs=oebfRd4-T-ry+4Ge7A@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<ZG/[email protected]>
<CALDaNm1sDD-MCW6zrxHCC7Ka5AzO-L4ejxeeTMtXPPN+F4vz2Q@mail.gmail.com>
<[email protected]>
<CALDaNm3SWpFDTs1oRRbOAfYJNuSPMCLu4O3mLnU-tKoSFgGckQ@mail.gmail.com>
<[email protected]>
<CALDaNm2Q_uE0Ash_1LTbqDQGSEM-8e9wjtuJ0QKTVdKNG34JWg@mail.gmail.com>
<CALj2ACVQovWdxd1C9K86JAtG4mTbh86qqXfKHjWw0BeLXAHE3g@mail.gmail.com>
<[email protected]>
<CALj2ACVE+vQK9gDKoNqSm+-aJxY=6OY7QJYFoc4oNFqy-BU_bA@mail.gmail.com>
<[email protected]>
On Fri, Jun 9, 2023 at 8:29 AM Michael Paquier <[email protected]> wrote:
>
> On Tue, Jun 06, 2023 at 05:53:40PM +0530, Bharath Rupireddy wrote:
> > Yes. A simpler way of doing it would be to move advance_wal() in
> > 019_replslot_limit.pl to Cluster.pm, something like the attached. CI
> > members don't complain with it
> > https://github.com/BRupireddy/postgres/tree/add_a_function_in_Cluster.pm_to_generate_WAL.
> > Perhaps, we can name it better instead of advance_wal, say
> > generate_wal or some other?
>
> Why not discussing that on a separate thread? What you are proposing
> is independent of what Vignesh has proposed.
Sure. Here it is -
https://www.postgresql.org/message-id/CALj2ACU3R8QFCvDewHCMKjgb2w_-CMCyd6DAK%3DJb-af14da5eg%40mail.g....
> Note that the patch
> format is octet-stream, causing extra CRs to exist in the patch.
> Something happened on your side when you sent your patch, I guess?
Had to attach the patch in .txt format to not block Vignesh's patch
from testing by CF Bot (if at all this thread was added there).
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
view thread (15+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Implement generalized sub routine find_in_log for tap test
In-Reply-To: <CALj2ACWJ8OOQ97=EDjy-i9Jdno5ioHs=oebfRd4-T-ry+4Ge7A@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox