public inbox for [email protected]
help / color / mirror / Atom feedFrom: Zsolt Parragi <[email protected]>
To: Jelte Fennema-Nio <[email protected]>
Cc: Jacob Champion <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: Dave Cramer <[email protected]>
Cc: Heikki Linnakangas <[email protected]>
Subject: Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
Date: Tue, 24 Mar 2026 22:21:19 +0000
Message-ID: <CAN4CZFPYS4iDCK3oYs3zp77K50ra6C=Hvg5-ymt9KR0OFmuGQA@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<[email protected]>
<[email protected]>
<CAN4CZFOw2v9G_9vuP0vnNH8K9X_UeSOyq=gWJp7bdGZ5HKNTDA@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAN4CZFMLpakQb8qohDAnrOoQ1-UrvmzJewZss95Y+Mf_J+iNeA@mail.gmail.com>
<[email protected]>
<[email protected]>
<CAOYmi+mAJ5jF-XrxFz1BAcAPfJCm9Yy1uvRNwfNz8q+1YMKDig@mail.gmail.com>
<[email protected]>
+ if (!goaway_reported && PQgoAwayReceived(pset.db))
+ {
+ pg_log_info("Server sent GoAway, requesting disconnect when convenient.");
+ goaway_reported = true;
+ }
Shouldn't this variable be reset in pqDropServerData?
+ It is possible for NoticeResponse, ParameterStatus and GoAway
messages to be
interspersed between CopyData messages; frontends must handle these cases,
The patch currently doesn't actually do this, did you add this as
future proofing?
> I thought some more about this, but ultimately, the payloads you suggest
> only seem useful if a client has something inbetween "disconnect hard
> now" and "disconnect when the connection is unused"
Couldn't a client optimize the reconnect time if it knows about the
deadline? If it knows that it still has 10 minutes before the server
kicks it out, it might choose to finish a 3-4 minute task, reconnect,
and then continue.
view thread (15+ messages) latest in thread
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
In-Reply-To: <CAN4CZFPYS4iDCK3oYs3zp77K50ra6C=Hvg5-ymt9KR0OFmuGQA@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox