public inbox for [email protected]
help / color / mirror / Atom feedFrom: John Naylor <[email protected]>
To: cca5507 <[email protected]>
Cc: zengman <[email protected]>
Cc: pgsql-hackers <[email protected]>
Subject: Re: tuple radix sort
Date: Wed, 29 Apr 2026 16:24:50 +0700
Message-ID: <CANWCAZaaGcp6OQyK9WuB3V9Lp5xctNB3WNWiqo+TopUKvJDbLQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <CANWCAZYzx7a7E9AY16Jt_U3+GVKDADfgApZ-42SYNiig8dTnFA@mail.gmail.com>
<CANWCAZbsx5VY-F5RVvZ5H1abBWcinMY90gNra6EbdGS1CTx=7g@mail.gmail.com>
<CANWCAZaN8kW6o7Ymc_jzPO_Z5SqekQTTNra3xTGYTH+cjrVp8g@mail.gmail.com>
<[email protected]>
<CANWCAZZiMGj6QuHfyBPv9at7xn23NPAz4nit=G6fr26V+h8MKg@mail.gmail.com>
<[email protected]>
<CANWCAZaKRzsYPn9YWRR8g5dkX-ep_jgyUb4r3KFekK5ZTNo7ew@mail.gmail.com>
<[email protected]>
<CANWCAZaBeDPfF0sCdSssRXv6nBZeRP8Z=OO1731zsoUC58U5_Q@mail.gmail.com>
<[email protected]>
<[email protected]>
<CANWCAZZo5rgE4+NYYES1hLN9PvonXMH=K3Z7b0TKcCBNOAjaag@mail.gmail.com>
<[email protected]>
<CANWCAZYur4VDbx9zkpFM3mM4-Hj4_Vt1t=Z4TPhK7+3=T6BMOA@mail.gmail.com>
<[email protected]>
<CANWCAZYBgHCpS-w5E8+wJpfhwLK88Kys-5ukSta2gj4BRPiTSg@mail.gmail.com>
<[email protected]>
<[email protected]>
<CANWCAZZA_AqWy7xw20O=jWG+t0Cy4rUnvs1RaAABvSp3iLnGhg@mail.gmail.com>
<[email protected]>
<CANWCAZaWV09=HdiF9mm7CBggFvxGkkHhhkSqyFoochQzW=RxAA@mail.gmail.com>
<CANWCAZZuQPMAPoCUQo7E2v2Zk5z9T=8bE=VGpC8_TYG3aomGyQ@mail.gmail.com>
<[email protected]>
<CANWCAZacXFMeG=afHF+3rxuyr3=0UcdNgxO8wTZ58fOzvyhwNw@mail.gmail.com>
<[email protected]>
<CANWCAZZzXHoDpCx394OAhu0ppW_OanbJzYifVwuALeNMhmF8TA@mail.gmail.com>
<[email protected]>
On Wed, Apr 8, 2026 at 3:20 PM cca5507 <[email protected]> wrote:
>
> > I also thought we should change this cast:
> >
> > if (ssup->comparator == ssup_datum_signed_cmp)
> > {
> > - norm_datum1 = orig + ((uint64) PG_INT64_MAX) + 1;
> > + norm_datum1 = orig + (Int64GetDatum(PG_INT64_MAX)) + 1;
> > }
> >
> > Upthread you mention something else about treating Datum as an
> > integer, but I'm not sure if this is what you meant since you didn't
> > say. If you have concrete suggestions, feel free to share them.
>
> I think we can keep it as is now.
It's harmless, but see commit ff89e182d.
I included the assert along with the above and some small cosmetic
fixes I've been saving.
--
John Naylor
Amazon Web Services
view thread (47+ messages)
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected]
Subject: Re: tuple radix sort
In-Reply-To: <CANWCAZaaGcp6OQyK9WuB3V9Lp5xctNB3WNWiqo+TopUKvJDbLQ@mail.gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox