public inbox for [email protected]  

help / color / mirror / Atom feed

From: John Naylor <[email protected]>
To: Tom Lane <[email protected]>
Cc: solaimurugan vellaipandiyan <[email protected]>
Cc: Aleksander Alekseev <[email protected]>
Cc: Payal Singh <[email protected]>
Cc: [email protected]
Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
Date: Mon, 11 May 2026 11:46:06 +0700
Message-ID: <CANWCAZbY43YfBVrsVwSafcxe4YdoaAwP1Keu9shcYA6GA=vnLQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAHEL7KRa-rmSCvREEYrdsY97PNgJtqLYfOikfZWEK4enNQhM0Q@mail.gmail.com>
	<[email protected]>

On Mon, May 11, 2026 at 6:37 AM Tom Lane <[email protected]> wrote:
> Attached are a proposed v8 of the patch, plus two diff files showing
> the effects.  v7-0001.diff.nocfbot is what the v7 patch does with
> today's HEAD (it's the same as before).  The v8 patch makes all those
> changes and in addition makes the ones shown in v8-0001.diff.nocfbot.
> I think those are pretty much all improvements, except that it kind
> of messes up Martin Utesch's ASCII-art signatures in the geqo files.

Agreed, although this one now seems to use even more vertical space
that doesn't contain anything:

-/* Function works as follows:
+/*
+ * Function works as follows:
+ *
  *
  *
- * */
+ */


-- 
John Naylor
Amazon Web Services

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Review - Patch for pg_bsd_indent: improve formatting of multiline comments
  In-Reply-To: <CANWCAZbY43YfBVrsVwSafcxe4YdoaAwP1Keu9shcYA6GA=vnLQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox