public inbox for [email protected]  

help / color / mirror / Atom feed

From: Shinya Kato <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Nathan Bossart <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Postgres hackers <[email protected]>
Subject: Re: Partitioned tables and [un]loggedness
Date: Thu, 5 Jun 2025 10:04:23 +0900
Message-ID: <CAOzEurS=3xu8WV6KRmc-axLn5tUs_5Ggy0DY_Gj8XcFOJTDeWQ@mail.gmail.com> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<ZurvG45F3lQHLw4G@nathan>
	<Zur4qqhABOXtZS8h@nathan>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAOzEurQZ1a+6d1K8b=+Ww1NFQVwAt9KSCQsBWXYBaPnYCenK3g@mail.gmail.com>
	<CAOzEurRRfPaZn_ZGmoDz2C3+74SAhk+FUZo_9oB1Zg_rQNGkYA@mail.gmail.com>
	<aEBxIcAiiDVlQvdx@nathan>
	<[email protected]>

On Thu, Jun 5, 2025 at 9:23 AM Michael Paquier <[email protected]> wrote:
> Agreed to not suggest the PARTITION BY clause in the tab completion as
> it is not supported by the backend for unlogged tables.
> tab-complete.in.c has some handling for CREATE UNLOGGED TABLE around
> line 3667, so we could just have an extra case for it, like in the
> attached patch.  A split already exists for temporary tables to handle
> the ON COMMIT clause after the attribute list.
>
> Thoughts?

Thank you. It looks good to me.

-- 
Best regards,
Shinya Kato
NTT OSS Center

view thread (20+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Partitioned tables and [un]loggedness
  In-Reply-To: <CAOzEurS=3xu8WV6KRmc-axLn5tUs_5Ggy0DY_Gj8XcFOJTDeWQ@mail.gmail.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox